some imports survive a kill -SIGTERM leading to massive log output and no kill
Bug #735477 reported by
Vincent Ladeuil
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Distributed Development |
Fix Released
|
High
|
Vincent Ladeuil |
Bug Description
Now that we have a time quota check, we try to kill the imports that exceed their quota.
It turns out nexuiz-data couldn't be killed and we kept trying.
I couldn't kill the import either with -15 (SIGTERM hoping to get a traceback) so I had to -9 (SIGKILL) it manually.
The mass_import script should probably do the same.
I don't have a good answer for the failure recording in that case since the process won't produce a meaning full output so we probably should rely on log analysis there.
Related branches
lp:~vila/udd/735477-kill-harder
- John A Meinel: Approve
- Martin Pool: Needs Fixing
-
Diff: 366 lines (+156/-56)4 files modifiedicommon.py (+37/-6)
tests.py (+73/-50)
tests/die_on_sigterm.py (+22/-0)
tests/survive_sigterm.py (+24/-0)
Changed in udd: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in udd: | |
status: | In Progress → Fix Released |
To post a comment you must log in.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 3/15/2011 2:50 PM, Vincent Ladeuil wrote:
> Public bug reported:
>
> Now that we have a time quota check, we try to kill the imports that
> exceed their quota.
>
> It turns out nexuiz-data couldn't be killed and we kept trying.
>
> I couldn't kill the import either with -15 (SIGTERM hoping to get a
> traceback) so I had to -9 (SIGKILL) it manually.
>
> The mass_import script should probably do the same.
>
> I don't have a good answer for the failure recording in that case since
> the process won't produce a meaning full output so we probably should
> rely on log analysis there.
If it is in swap death, or dying inside a C function, then SIGTERM and
SIGINT won't work (AIUI). If we know what function it was dying in (and
it is one of ours), we could add a call to the Python "check if there
are pending signals" function. With some tricks to watch out for GIL issues.
John
=:->
-----BEGIN PGP SIGNATURE----- enigmail. mozdev. org/
/fqUACgkQJdeBCY SNAANzOgCfeCwCg 6gwYIQfoDC4uTIV n+t4 tUFFHzhov4y4kAy IZ
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
YpgAn35QdL1wwtz
=6gUI
-----END PGP SIGNATURE-----