Launchpad itself

Poppy FTP server returning "426 transfer aborted" errors for .changes files

Bug #732638 reported by Jani Monoses
32
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Unassigned

Bug Description

Since the March 10 FTP server upgrade, several people got errors from dput.

Example output. Note the last line and the GPG warnings in the middle

Trying to upload package to ubuntu
Checking signature on .changes
gpg: Signature made Thu 10 Mar 2011 04:34:52 PM EET using DSA key ID C5AA2301
gpg: Good signature from "Jani Monoses <email address hidden>"
gpg: aka "Jani Monoses <email address hidden>"
gpg: aka "Jani Monoses <email address hidden>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 9FB2 ACAF 024D 40B9 1646 01F4 540A 6E1B C5AA 2301
Good signature on /home/jani/work/packaging/webkit/webkit_1.3.12-0ubuntu3_source.changes.
Checking signature on .dsc
gpg: Signature made Thu 10 Mar 2011 04:34:52 PM EET using DSA key ID C5AA2301
gpg: Good signature from "Jani Monoses <email address hidden>"
gpg: aka "Jani Monoses <email address hidden>"
gpg: aka "Jani Monoses <email address hidden>"
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the owner.
Primary key fingerprint: 9FB2 ACAF 024D 40B9 1646 01F4 540A 6E1B C5AA 2301
Good signature on /home/jani/work/packaging/webkit/webkit_1.3.12-0ubuntu3.dsc.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading webkit_1.3.12-0ubuntu3.dsc: done.
  Uploading webkit_1.3.12-0ubuntu3.debian.tar.gz: done.
  Uploading webkit_1.3.12-0ubuntu3_source.changes: 2k/3k426 Transfer aborted. Data connection closed.

Despite the error message the upload succeeded.

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: Some Poppy GPG signature validity check warnings can be ignored

I suspect that the code in lib/lp/poppy/twistedftp.py: PoppyFileWriter.validateGPG() should be ignoring some kinds of errors. The dput warning here is probably indicative of the problem.

summary: - FTP server prints error on dput
+ Some Poppy GPG signature validity check warnings can be ignored
Changed in launchpad:
status: New → Triaged
importance: Undecided → Critical
tags: added: poppy
Revision history for this message
Jani Monoses (jani) wrote :
Revision history for this message
Julian Edwards (julian-edwards) wrote :

We poked a change in ~/.gnupg/gpg.conf to see if this corrects the problem (hat tip to ~maxb), please reply and let me know if your error goes away.

Changed in launchpad:
status: Triaged → Incomplete
Revision history for this message
Julian Edwards (julian-edwards) wrote :

Apparently it doesn't go away. My latest investigation shows that the log file has stopped updating. I think there's some logging problem here, which is probably causing the verification to fail when it tries to log something.

Changed in launchpad:
status: Incomplete → Triaged
summary: - Some Poppy GPG signature validity check warnings can be ignored
+ Poppy FTP server returning "426 transfer aborted" errors for .changes
+ files
Revision history for this message
Julian Edwards (julian-edwards) wrote :

I should add that the upload makes it through ok, it's just the connection is aborted instead of being closed normally.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

I'll lay a wager on something being wrong with the code in daemons/poppy-sftp.tac:

{{{
# Connect Python logging to Twisted's logging.
from lp.services.twistedsupport.loggingsupport import set_up_tacfile_logging
set_up_tacfile_logging("poppy-sftp", logging.INFO)
}}}

Revision history for this message
William Grant (wgrant) wrote :

We've reverted to the old poppy for FTP. Both are working fine now.

tags: added: regression soyuz-upload
Revision history for this message
Robert Collins (lifeless) wrote :

I've reopened the bug that the new poppy solves.

Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.