translation uploads from source package builds should stop when upstream sharing is enabled.
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Abel Deuring | ||
Bug Description
Currently, templates and translations for source packages are uploaded by soyuz after the package has been built. Once the source package has upstream translations sharing configured correctly, the translations from the build should be discarded and only the template get uploaded to the package. Translations will then be pulled from the upstream source tree. If translations would still be imported to the source package, these would overwrite the translations done in Launchpad, which is something we don't want.
This should be fixed by using has_upstream_
Related branches
- Leonard Richardson (community): Approve
-
Diff: 351 lines (+111/-35)5 files modifiedlib/lp/soyuz/doc/distroseriesqueue-translations.txt (+13/-8)
lib/lp/soyuz/interfaces/queue.py (+9/-7)
lib/lp/soyuz/model/queue.py (+22/-13)
lib/lp/soyuz/model/sourcepackagerelease.py (+11/-6)
lib/lp/soyuz/tests/test_sourcepackagerelease.py (+56/-1)
- Abel Deuring (community): Approve (code)
-
Diff: 620 lines (+173/-76)16 files modifiedlib/lp/registry/model/distribution.py (+2/-5)
lib/lp/registry/model/distroseries.py (+14/-8)
lib/lp/registry/model/product.py (+2/-1)
lib/lp/registry/model/productseries.py (+4/-0)
lib/lp/registry/model/sourcepackage.py (+4/-0)
lib/lp/soyuz/model/sourcepackagerelease.py (+7/-14)
lib/lp/soyuz/tests/test_sourcepackagerelease.py (+10/-14)
lib/lp/translations/browser/productseries.py (+1/-4)
lib/lp/translations/browser/sourcepackage.py (+2/-8)
lib/lp/translations/doc/translationimportqueue.txt (+28/-3)
lib/lp/translations/interfaces/hastranslationtemplates.py (+11/-4)
lib/lp/translations/interfaces/translationimportqueue.py (+4/-1)
lib/lp/translations/model/hastranslationtemplates.py (+16/-0)
lib/lp/translations/model/translationimportqueue.py (+7/-3)
lib/lp/translations/tests/test_hastranslationtemplates.py (+60/-7)
lib/lp/translations/utilities/translation_import.py (+1/-4)
| description: | updated |
| Changed in launchpad: | |
| assignee: | nobody → Abel Deuring (adeuring) |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| milestone: | none → 11.04 |
| tags: |
added: qa-needstesting removed: qa-bad |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-untestable removed: qa-needstesting |
| William Grant (wgrant) wrote | #4 |
| tags: |
added: qa-ok removed: qa-untestable |
| tags: |
added: bad-commit-12647 qa-bad removed: qa-ok |
| William Grant (wgrant) wrote | #5 |
| tags: |
added: qa-ok removed: bad-commit-12647 qa-bad |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
Bug 741571 needs to be fixed to make this QA ok.