bzr-builddeb

use launchpad upstream branch information

Bug #726460 reported by Jelmer Vernooij
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
bzr-builddeb
Fix Released
Medium
Jelmer Vernooij
bzr-builddeb 2.7.3

Bug Description

bzr-builddeb can currently use .bzr-builddeb/{default.conf,local.conf} to find the upstream branch location. However, in a lot of situations Launchpad also has this information. It would be great if bzr-builddeb could use launchpad to find this information if it is not present in the local branch.

Related branches

lp:~jelmer/bzr-builddeb/launchpad-upstream
James Westby: Approve
Diff: 162 lines (+72/-17)
3 files modified
cmds.py (+28/-16)
debian/changelog (+2/-0)
launchpad.py (+42/-1)
lp:ubuntu/oneiric/bzr-builddeb
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

I have a branch for this that seems to be working well.

However, an issue is that some existing branches don't have any relation with upstream. Is that an issue? Should we perhaps hide this functionality behind an option, or maybe check for some shared ancestry before using the lp branch?

Changed in bzr-builddeb:
assignee: nobody → Jelmer Vernooij (jelmer)
status: Triaged → In Progress
Revision history for this message
James Westby (james-w) wrote : Re: [Bug 726460] Re: use launchpad upstream branch information

On Fri, 04 Mar 2011 16:37:41 -0000, Jelmer Vernooij <email address hidden> wrote:
> I have a branch for this that seems to be working well.
>
> However, an issue is that some existing branches don't have any relation
> with upstream. Is that an issue? Should we perhaps hide this
> functionality behind an option, or maybe check for some shared ancestry
> before using the lp branch?

I think if we automatically use something that will cause an error with
no way to disable it that would be bad.

I think that checking shared ancestry would be a good idea though, if
this is cheap (and there should perhaps still be an option to disable
this, because it will crash if you have no network say.)

Thanks,

James

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

On Tue, 2011-03-08 at 23:39 +0000, James Westby wrote:
> On Fri, 04 Mar 2011 16:37:41 -0000, Jelmer Vernooij <email address hidden> wrote:
> > I have a branch for this that seems to be working well.
> >
> > However, an issue is that some existing branches don't have any relation
> > with upstream. Is that an issue? Should we perhaps hide this
> > functionality behind an option, or maybe check for some shared ancestry
> > before using the lp branch?
> I think if we automatically use something that will cause an error with
> no way to disable it that would be bad.
 It would be the last resort (we would only ask Launchpad if all other
ways to find the upstream URL fails).

That said, perhaps it's indeed best to have an option for now. We can
always decide to make it the default fallback if it works well.

> I think that checking shared ancestry would be a good idea though, if
> this is cheap (and there should perhaps still be an option to disable
> this, because it will crash if you have no network say.)
It should be fairly cheap, just browsing the revision graph.

Cheers,

Jelmer

Jelmer Vernooij (jelmer)
Changed in bzr-builddeb:
status: In Progress → Fix Released
milestone: none → 2.7.3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.