SD creates new notifications instead of updating one
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
High
|
Eric Casteleijn | ||
ubuntuone-client (Ubuntu) |
Fix Released
|
Medium
|
Eric Casteleijn | ||
Natty |
Fix Released
|
Medium
|
Eric Casteleijn |
Bug Description
<rye> alecu, do we do .update() on pynotify messages or just show() or something like that?
<alecu> rye, we only update the message when new files are found while showing the new files notification.
<rye> alecu, i think you should use notification.
<dobey> alecu: yeah what rye said, you have to update, then .show
<dobey> you never just do .update
<dobey> if you're just doing .update somewhere without a .show after, it's a bug
The notification code uses creates new notification for various conditions and sometimes updates old one. Sometimes it can create a backlog of notifications (since notifiy-osd is showing one at a time). Notification code should create one notification and then update() that and show().
Related branches
- dobey (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 255 lines (+29/-110)6 files modifiedtests/platform/linux/test_notification.py (+17/-21)
tests/status/test_aggregator.py (+2/-56)
ubuntuone/platform/linux/notification.py (+8/-12)
ubuntuone/platform/windows/notification.py (+0/-5)
ubuntuone/status/aggregator.py (+2/-11)
ubuntuone/status/notification.py (+0/-5)
Changed in ubuntuone-client: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Eric Casteleijn (thisfred) |
tags: | added: desktop+ notifications |
tags: | added: u1-unity |
Changed in ubuntuone-client: | |
importance: | Medium → High |
status: | Confirmed → In Progress |
tags: | added: u1-natty |
Changed in ubuntuone-client (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Eric Casteleijn (thisfred) |
milestone: | none → ubuntu-11.04-beta-1 |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
tags: | added: u1-natty-beta |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package ubuntuone-client - 1.5.6-0ubuntu1
---------------
ubuntuone-client (1.5.6-0ubuntu1) natty; urgency=low
* New upstream release. CANCELLED is no more (LP: #721479)
- Remove already upstreamed patch
- Release pathlock when command cancelled (LP: #729158)
- syncdaemon continuously hashing (LP: #580855)
- Self conflict when saving the same file a lot (LP: #718924)
- SYS_QUOTA_EXCEEDED not being sent (LP: #720797)
- The check_condition call may be too heavy (LP: #720844)
- AQ_DOWNLOAD_
- SD should update a single notification (LP: #723227)
- Two entries in Messaging menu (LP: #721525)
- Singular form incorrect for notification (LP: #723327)
- File names should be shown on notifications (LP: #729055)
* Moved icon files to ubuntuone-client package (LP: #727195)
-- Rodney Dawes <email address hidden> Wed, 09 Mar 2011 21:11:44 -0500