ubuntu-geoip-provider should use uppercase HTTP method

Bug #719324 reported by Andrew Glen-Young
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-geoip (Ubuntu)
Fix Released
Medium
Brian Murray

Bug Description

According to rfc2616 HTTP request methods are case-sensitive. Currently ubunt-geoip-provider makes an HTTP GET request with a lowercase method name.

Example:
get /lookup HTTP/1.1

Expected:
GET /lookup HTTP/1.1

While web servers (like Apache and Squid) accept the lowercase method name, it may not be the case for some less liberal servers.

The change is near trivial and I've attached a patch to fix this.

Tags: patch pedantic

Related branches

Revision history for this message
Andrew Glen-Young (aglenyoung) wrote :
tags: added: patch
Changed in ubuntu-geoip (Ubuntu):
assignee: nobody → Brian Murray (brian-murray)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Brian Murray (brian-murray) wrote :

Here's a debdiff too in case the sponsor would prefer that.

Revision history for this message
Artur Rona (ari-tczew) wrote :

I unsubscribed ubuntu-sponsors since this patch is getting through lp:~brian-murray/ubuntu/natty/ubuntu-geoip/fix-719324

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-geoip - 0.0.2-0ubuntu5

---------------
ubuntu-geoip (0.0.2-0ubuntu5) natty; urgency=low

  * Per RFC 2616 use upper case for GET request thanks to Andrew Glen-Young
    for the patch (LP: #719324)
 -- Brian Murray <email address hidden> Fri, 04 Mar 2011 13:58:56 -0800

Changed in ubuntu-geoip (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
HaruSiga77 (tolkien-world) wrote :

Could some one please explain what ubuntu-geoip-partner is? Is it a beacon to the mother-ship? Jaja! I randomly found this when I set up a firewall. Been with Linux for about 5 years and started with Ubuntu. It would be sad to see Ubuntu regress into Windows. Remember that your community is what matters, else you'll lose the to Linux Mint. Give us options, give us freedom, and all that...

Revision history for this message
HaruSiga77 (tolkien-world) wrote :

Oh I use Precise-64bit.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.