Odoo Web Client

context not passed in tree_but_action

Bug #716300 reported by David Janssens on 2011-02-10

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Odoo Web Client	Won't Fix	Undecided	Unassigned
	5.0	Fix Released	Low	Jay Vora (Serpent Consulting Services)

Bug Description

In openerp web client 5 (not tested in 6), the context is not passed to the tree_but_action in tree views.
So for example, when clicking on an account in chart of account, it returns all entries of that account regardless of wizard parameters.
I made a patch to fix this:

=== modified file 'openerp/controllers/tree.py'
--- openerp/controllers/tree.py 2009-09-18 10:10:44 +0000
+++ openerp/controllers/tree.py 2011-02-10 08:44:46 +0000
@@ -191,7 +191,7 @@
record = {}

record['id'] = item.pop('id')
- record['action'] = url('/tree/open', model=model, id=record['id'])
+ record['action'] = url('/tree/open', model=model, id=record['id'], context=ctx)
record['target'] = None

record['icon'] = None
@@ -219,7 +219,7 @@
params, data = TinyDict.split(datas)

model = params.model
- context = params._terp_context or {}
+ context = params.context or {}
ids = data.get('ids') or []

ctx = rpc.session.context.copy()

Related branches

lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1

Merged into lp:~openerp-dev/openobject-addons/trunk-dev-addons3 at revision 4983

OpenERP R&D Team: Pending requested 2011-02-14

lp:~openerp-dev/openobject-addons/trunk-bug-716300-ara

Rejected for merging into lp:openobject-addons

Mustufa Rangwala (Open ERP) (community): Disapprove on 2011-04-21

qdp (OpenERP): Needs Information on 2011-04-20

lp:~openerp-dev/openobject-client-web/6.0-opw-5302-sma

Merged into lp:openobject-client-web at revision 4601

OpenERP Core Team: Pending requested 2011-05-10

lp:openobject-client-web/5.0

DBR (OpenERP) (dbr-openerp) on 2011-02-11

affects:	openobject-client-web → openobject-addons
Changed in openobject-addons:
assignee:	nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance:	Undecided → Low
status:	New → Confirmed

Meera Trambadia (OpenERP) (mtr-openerp) on 2011-02-11

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Meera Trambadia (OpenERP) (mtr-openerp) wrote on 2011-02-11:

Hello David Janssens,

Its fixed in https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1 branch.
Revision ID: mtr@mtr-20110211112737-esnj1iyhcwlqn87v
Revision no:4751

Thanks
mtr

Changed in openobject-addons:
status:	In Progress → Fix Committed

Revision history for this message

Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote on 2011-02-11:

For fiscalyear its not working.

Changed in openobject-addons:
status:	Fix Committed → Confirmed

Mustufa Rangwala (Open ERP) (mra-tinyerp) on 2011-02-11

Changed in openobject-addons:
milestone:	none → 6.1

Meera Trambadia (OpenERP) (mtr-openerp) on 2011-02-11

Changed in openobject-addons:
status:	Confirmed → In Progress
status:	In Progress → Fix Committed

Revision history for this message

Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote on 2011-02-11:

Fixed in Addons3

revision-id: mra@mra-laptop-20110211123951-c4d0qm3qsllztltr
revno: 4979

thank you,
mra

Changed in openobject-addons:
status:	Fix Committed → Fix Released

Revision history for this message

Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote on 2011-02-24:

We have reverted the code from Addons3 branch for now so i reopen the bug we will try to correct it with other good solution.

May be with domain/context on action of the opening journal items currently there is some limitation on gtk/webclient we can not use context.get() on domain with action.

Thank you,
mra

Changed in openobject-addons:
status:	Fix Released → Confirmed
milestone:	6.1 → none

Ashvin Rathod (OpenERP) (ara-tinyerp) on 2011-04-14

Changed in openobject-addons:
status:	Confirmed → In Progress

Revision history for this message

Ashvin Rathod (OpenERP) (ara-tinyerp) wrote on 2011-04-14:

Hello David Janssens,

Its fixed in lp:~openerp-dev/openobject-addons/trunk-bug-716300-ara branch. It will be merge soon with trunk addons.

Thanks for reporting.

Revision ID: <email address hidden>
Revision no:4640

Thanks,
ara

Changed in openobject-addons:
status:	In Progress → Fix Committed

Mustufa Rangwala (Open ERP) (mra-tinyerp) on 2011-04-14

Changed in openobject-addons:
milestone:	none → 6.1

Revision history for this message

Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote on 2011-04-21:

Hello,

As this bug is not related with Addons module.

Should be fix in gtk/webclient.

Thanks,
mra

Changed in openobject-addons:
status:	Fix Committed → Invalid
status:	Invalid → Confirmed

Mustufa Rangwala (Open ERP) (mra-tinyerp) on 2011-04-21

Changed in openobject-addons:
milestone:	6.1 → none

DBR (OpenERP) (dbr-openerp) on 2011-04-21

affects:	openobject-addons → openobject-client-web
Changed in openobject-client-web:
assignee:	OpenERP R&D Addons Team 3 (openerp-dev-addons3) → nobody
importance:	Low → Undecided
status:	Confirmed → New

DBR (OpenERP) (dbr-openerp) on 2011-04-21

Changed in openobject-client-web:
assignee:	nobody → OpenERP SA's Web Client R&D (openerp-dev-web)
importance:	Undecided → Low
status:	New → Confirmed

Sananaz (Open ERP) (sma-tiny) on 2011-05-10

Changed in openobject-client-web:
status:	Confirmed → In Progress

Revision history for this message

Sananaz (Open ERP) (sma-tiny) wrote on 2011-05-10:

Hello David Janssens,

The fix for web-client has been committed to lp:~openerp-dev/openobject-client-web/6.0-opw-5302-sma
with the following revision.

Revision-info:
4596 <email address hidden>

Soon it will be merged into trunk and stable web-client.

Thanks.

Changed in openobject-client-web:
status:	In Progress → Fix Committed

Revision history for this message

Jiten (OpenERP) (jiten-openerp) wrote on 2011-05-11:

Hello,

I have checked it with 6.0 stable web client and found the problem in form view only.

Produced the problem in WEB,
Example
Account - Chart of Accounts >
* set fiscal year as default -> does NOT copy periods into from/to into form.

So, i am convert this bug to 'Confirmed'.

Thanks!

Changed in openobject-client-web:
status:	Fix Committed → Confirmed

Revision history for this message

Vinay Rana (OpenERP) (vra-openerp) wrote on 2011-08-16:

This bug is being closed as Won't Fix in the OpenERP Web Client project, as it is not going to be developed further after the 6.0 series. It will be replaced in 6.1 by a newer and better web frontend known as the OpenERP Web project[1], so further R&D efforts on the 6.0 project would be wasted.
Bugs affecting customers in production of course continue to be handled via the OpenERP Enterprise (OPW) maintenance service.
You can find more details about this in the Bug Management FAQ[2].

Changed in openobject-client-web:
assignee:	OpenERP R&D Web Team (openerp-dev-web) → nobody
importance:	Low → Undecided
status:	Confirmed → Won't Fix

Report a bug

This report contains Public information

Everyone can see this information.

Duplicates of this bug

Bug #780816

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.