does not send mail on superseded proposals
Bug #716169 reported by
Martin Pool
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Colin Watson | ||
Bug Description
Launchpad sends mail when an mp is created, but not when an existing one is superseded. For people tracking the discussion only through mail this causes confusion about which one they should actually review.
Related branches
lp:~cjwatson/launchpad/consistent-bmp-events
- William Grant: Approve (code)
-
Diff: 863 lines (+268/-96)17 files modifiedlib/lp/code/browser/branchmergeproposal.py (+1/-12)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+140/-6)
lib/lp/code/configure.zcml (+2/-2)
lib/lp/code/event/branchmergeproposal.py (+1/-14)
lib/lp/code/interfaces/event.py (+0/-10)
lib/lp/code/mail/codehandler.py (+9/-7)
lib/lp/code/mail/tests/test_codehandler.py (+21/-1)
lib/lp/code/model/branchmergeproposal.py (+0/-4)
lib/lp/code/model/branchmergeproposaljob.py (+1/-0)
lib/lp/code/model/tests/test_branchmergeproposal.py (+7/-7)
lib/lp/code/model/tests/test_codereviewcomment.py (+3/-2)
lib/lp/code/model/tests/test_codereviewkarma.py (+12/-5)
lib/lp/code/model/tests/test_gitrepository.py (+17/-3)
lib/lp/code/subscribers/branchmergeproposal.py (+13/-8)
lib/lp/code/subscribers/karma.py (+15/-6)
lib/lp/codehosting/scanner/tests/test_mergedetection.py (+10/-2)
lib/lp/testing/__init__.py (+16/-7)
| tags: |
added: email notifications removed: mail |
| Changed in launchpad: | |
| importance: | High → Low |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17807 <http://