Odoo Addons (MOVED TO GITHUB)

[PS] sale margin module : wrong computation

Bug #715470 reported by Francois Pietquin (OpenERP)
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Medium
OpenERP R&D Addons Team 3
Odoo Addons (MOVED TO GITHUB) 6.1

Bug Description

6.0.1
gtk client
linux

Sale Margin module: the margin computed in the Sale Order form is not correct. It doesn't take into account the first line of the basket. If two or more lines are presents, the margin is computed using lines 2 to x but never the first line.

Francois Pietquin
Professional services

Related branches

lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-ara
OpenERP R&D Team: Pending requested
Diff: 19 lines (+2/-2)
1 file modified
account/partner_view.xml (+2/-2)
lp:~openerp-dev/openobject-addons/trunk-bug-715470-ksa
Rejected for merging into lp:openobject-addons
Mustufa Rangwala (Open ERP) (community): Needs Fixing
Diff: 91 lines (+29/-17)
2 files modified
sale_margin/sale_margin.py (+16/-16)
sale_margin/sale_margin_view.xml (+13/-1)
lp:~openerp-dev/openobject-addons/trunk-bug-715470-ara
qdp (OpenERP): Approve
OpenERP buildbot (community): Needs Fixing
Mustufa Rangwala (Open ERP) (community): Approve
Ashvin Rathod (OpenERP) (community): Needs Resubmitting
Olivier Dony (Odoo): Pending requested
Diff: 29 lines (+9/-2)
1 file modified
sale_margin/sale_margin.py (+9/-2)
lp:openobject-server
Francois Pietquin (OpenERP) (fpi-openerp)
summary: - sale margin module : wrong computation
+ [PS] sale margin module : wrong computation
Pieter J. Kersten (EduSense BV) (pieterj)
affects: account-banking → openobject-addons
Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Francois,

Thanks for the reporting and I am confirming this issue.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Medium
status: New → Confirmed
Ashvin Rathod (OpenERP) (ara-tinyerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

francois,

The problem is that margin field on sale order is function field and margin field on sale.order.line is also function field.

So when we create the sale order first time and make one line on it and save the sale order it first calls margin field function field on sale order and then called margin field on sale.order.line.

So we get null value for margin (sale.order.line) in margin(sale.order).

so the problem you describe is not real problem but its due to store functionality on server.

thanks,
mra

Changed in openobject-addons:
milestone: none → 6.1
Revision history for this message
Ashvin Rathod (OpenERP) (ara-tinyerp) wrote :

Hello francois,

I have fixed the problem in lp:~openerp-commiter/openobject-addons/trunk-dev-addons3-ara branch, It will be merged soon with trunk-dev-addons3.

Revision ID: <email address hidden>
Revision No: 4710

Thank you,
ARA

Changed in openobject-addons:
status: In Progress → Fix Committed
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

Hello,

It should be fixed by Store={} functionality.
So i reopen the bug.

Thank you,
mra

Changed in openobject-addons:
status: Fix Released → Confirmed
Revision history for this message
Mustufa Rangwala (Open ERP) (mra-tinyerp) wrote :

I have reverted the changes from Addons3 branch.

Revision history for this message
Carlos Incaser (carlos-incaser) wrote :

Sorry for the duplication, but the bug 723448 I have given the solution to the problem with some improvements.

Kirti Savalia(OpenERP) (ksa-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Mustufa Rangwala (Open ERP) (mra-tinyerp)
Changed in openobject-addons:
status: In Progress → Confirmed
milestone: 6.1 → none
Ashvin Rathod (OpenERP) (ara-tinyerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Ashvin Rathod (OpenERP) (ara-tinyerp) wrote :

Hello Francois,

I have fixed the problem in lp:~openerp-dev/openobject-addons/trunk-bug-715470-ara branch, It will be merged soon with openobject-addons.

Revision ID: <email address hidden>

Thanks,
ara

Changed in openobject-addons:
status: In Progress → Fix Committed
Fabien (Open ERP) (fp-tinyerp)
Changed in openobject-addons:
status: Fix Committed → Fix Released
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

The fix landed at revision 5021 revid:<email address hidden> in trunk.

Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

The corresponding server-side fix landed in trunk at revision 3612 rev-id: <email address hidden>

Serpent Consulting Services (serpent-consulting-services)
Changed in openobject-addons:
milestone: none → 6.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.