Percona Server moved to https://jira.percona.com/projects/PS

rename enable_query_response_time option in 5.5

Bug #714884 reported by Vadim Tkachenko
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
High
Oleg Tsarev
Percona Server moved to https://jira.percona.com/projects/PS 5.5-20beta

Bug Description

We should rename enable_query_response_time to query_response_time in Percona Server 5.5 and make sure it works as boolean variable in my.cnf and command line.

Related branches

lp:~percona-dev/percona-server/fix-714884
Alexey Kopytov (community): Approve
Fred Linhoss (community): Approve (documentation)
Diff: 458 lines (+72/-72)
7 files modified
mysql-test/response-time-distribution.patch/percona_query_response_time-replication.result (+2/-2)
mysql-test/response-time-distribution.patch/percona_query_response_time-replication.test (+2/-2)
mysql-test/response-time-distribution.patch/percona_query_response_time-stored.result (+23/-23)
mysql-test/response-time-distribution.patch/percona_query_response_time-stored.test (+15/-15)
mysql-test/response-time-distribution.patch/percona_query_response_time.result (+11/-11)
mysql-test/response-time-distribution.patch/percona_query_response_time.test (+11/-11)
response_time_distribution.patch (+8/-8)
lp:~percona-dev/percona-server/5.5.8
Oleg Tsarev (community): Disapprove
Diff: 37420 lines (+36564/-0) (has conflicts)
158 files modified
COPYING.innodb-deadlock-count-patch (+30/-0)
COPYING.show_temp_51 (+13/-0)
Makefile (+68/-0)
bug580324.patch (+105/-0)
control_online_alter_index.patch (+90/-0)
error_pad.patch (+267/-0)
innodb_adaptive_hash_index_partitions.patch (+1508/-0)
innodb_admin_command_base.patch (+173/-0)
innodb_buffer_pool_pages_i_s.patch (+803/-0)
innodb_buffer_pool_shm.patch (+1224/-0)
innodb_deadlock_count.patch (+71/-0)
innodb_dict_size_limit.patch (+446/-0)
innodb_expand_import.patch (+561/-0)
innodb_extend_slow.patch (+1034/-0)
innodb_extra_rseg.patch (+273/-0)
innodb_fast_checksum.patch (+301/-0)
innodb_files_extend.patch (+523/-0)
innodb_fix_misc.patch (+206/-0)
innodb_io_patches.patch (+1111/-0)
innodb_lru_dump_restore.patch (+677/-0)
innodb_opt_lru_count.patch (+314/-0)
innodb_overwrite_relay_log_info.patch (+495/-0)
innodb_pass_corrupt_table.patch (+1387/-0)
innodb_recovery_patches.patch (+504/-0)
innodb_separate_doublewrite.patch (+1078/-0)
innodb_show_lock_name.patch (+412/-0)
innodb_show_status.patch (+447/-0)
innodb_show_sys_tables.patch (+1734/-0)
innodb_split_buf_pool_mutex.patch (+3955/-0)
innodb_stats.patch (+2404/-0)
innodb_thread_concurrency_timer_based.patch (+191/-0)
install_tests.sh (+19/-0)
log_connection_error.patch (+53/-0)
log_warnings_silence.patch (+85/-0)
lrusort.py (+38/-0)
microsec_process.patch (+52/-0)
mysql-test.diff (+828/-0)
mysql-test/log_connection_error.patch/percona_log_connection_error-master.opt (+1/-0)
mysql-test/log_connection_error.patch/percona_log_connection_error.result (+15/-0)
mysql-test/log_connection_error.patch/percona_log_connection_error.test (+52/-0)
mysql-test/log_warnings_silence.patch/percona_log_warnings_silence-master.opt (+1/-0)
mysql-test/log_warnings_silence.patch/percona_log_warnings_silence.result (+31/-0)
mysql-test/log_warnings_silence.patch/percona_log_warnings_silence.test (+47/-0)
mysql-test/percona_innodb_buffer_pool_shm-master.opt (+1/-0)
mysql-test/percona_innodb_buffer_pool_shm.result (+6/-0)
mysql-test/percona_innodb_buffer_pool_shm.test (+18/-0)
mysql-test/percona_innodb_deadlock_count.result (+28/-0)
mysql-test/percona_innodb_deadlock_count.test (+49/-0)
mysql-test/percona_innodb_doublewrite_file-master.opt (+1/-0)
mysql-test/percona_innodb_doublewrite_file.result (+4/-0)
mysql-test/percona_innodb_doublewrite_file.test (+2/-0)
mysql-test/percona_innodb_use_sys_stats_table-master.opt (+1/-0)
mysql-test/percona_innodb_use_sys_stats_table.result (+3/-0)
mysql-test/percona_innodb_use_sys_stats_table.test (+2/-0)
mysql-test/percona_server_variables.result (+342/-0)
mysql-test/percona_server_variables.test (+7/-0)
mysql-test/percona_show_temp_tables.result (+58/-0)
mysql-test/percona_show_temp_tables.test (+65/-0)
mysql-test/percona_suppress_log_warning_1592-master.opt (+1/-0)
mysql-test/percona_suppress_log_warning_1592.result (+28/-0)
mysql-test/percona_suppress_log_warning_1592.test (+46/-0)
mysql-test/percona_xtradb_admin_command.result (+6/-0)
mysql-test/percona_xtradb_admin_command.test (+3/-0)
mysql-test/percona_xtradb_bug317074.result (+4/-0)
mysql-test/percona_xtradb_bug317074.test (+47/-0)
mysql-test/profiling_slow.patch/percona_bug643149.result (+16/-0)
mysql-test/profiling_slow.patch/percona_bug643149.test (+47/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments.inc (+95/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments.inc.backup (+88/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments.result (+866/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments.test (+5/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_begin.inc (+12/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_clear.inc (+5/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_crash.result (+21/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_crash.test (+22/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_disable.result (+865/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_disable.test (+3/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_end.inc (+3/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_eval.inc (+7/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_prepared_statements.result (+396/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_prepared_statements.test (+208/-0)
mysql-test/query_cache_enhance.patch/percona_query_cache_with_comments_show.inc (+8/-0)
mysql-test/query_cache_enhance.patch/percona_status_wait_query_cache_mutex.result (+27/-0)
mysql-test/query_cache_enhance.patch/percona_status_wait_query_cache_mutex.test (+37/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time-replication.result (+70/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time-replication.test (+56/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time-stored.result (+313/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time-stored.test (+90/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time.result (+567/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time.test (+68/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time_flush.inc (+1/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time_show.inc (+8/-0)
mysql-test/response-time-distribution.patch/percona_query_response_time_sleep.inc (+19/-0)
mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.result (+26/-0)
mysql-test/show_slave_status_nolock.patch/percona_show_slave_status_nolock.test (+39/-0)
mysql-test/slow_extended.patch/percona_slow_extended-control_global_slow-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-control_global_slow.result (+11/-0)
mysql-test/slow_extended.patch/percona_slow_extended-control_global_slow.test (+9/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_filter-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_filter.result (+24/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_filter.test (+30/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_sp_statements-cl-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_sp_statements-cl.result (+3/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_sp_statements-cl.test (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_timestamp_every-cl-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_timestamp_every-cl.result (+3/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_timestamp_every-cl.test (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_verbosity-cl-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_verbosity-cl.result (+9/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_verbosity-cl.test (+3/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_verbosity-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_verbosity.result (+8/-0)
mysql-test/slow_extended.patch/percona_slow_extended-log_slow_verbosity.test (+10/-0)
mysql-test/slow_extended.patch/percona_slow_extended-long_query_time-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-long_query_time.result (+21/-0)
mysql-test/slow_extended.patch/percona_slow_extended-long_query_time.test (+16/-0)
mysql-test/slow_extended.patch/percona_slow_extended-microseconds_in_slow_extended-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-microseconds_in_slow_extended.result (+10/-0)
mysql-test/slow_extended.patch/percona_slow_extended-microseconds_in_slow_extended.test (+15/-0)
mysql-test/slow_extended.patch/percona_slow_extended-min_examined_row_limit-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-min_examined_row_limit.result (+24/-0)
mysql-test/slow_extended.patch/percona_slow_extended-min_examined_row_limit.test (+30/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_innodb_stats-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_innodb_stats-slave.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_innodb_stats.result (+21/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_innodb_stats.test (+44/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements-and-use_global_long_query_time-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements-and-use_global_long_query_time-slave.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements-and-use_global_long_query_time.result (+91/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements-and-use_global_long_query_time.test (+107/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements-slave.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements.result (+86/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slave_statements.test (+159/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slow_query_log_microseconds_timestamp-cl-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slow_query_log_microseconds_timestamp-cl.result (+3/-0)
mysql-test/slow_extended.patch/percona_slow_extended-slow_query_log_microseconds_timestamp-cl.test (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-use_global_long_query_time-master.opt (+1/-0)
mysql-test/slow_extended.patch/percona_slow_extended-use_global_long_query_time.result (+43/-0)
mysql-test/slow_extended.patch/percona_slow_extended-use_global_long_query_time.test (+34/-0)
mysql-test/sql_no_fcache.patch/percona_sql_no_fcache.result (+12/-0)
mysql-test/sql_no_fcache.patch/percona_sql_no_fcache.test (+11/-0)
mysql_dump_ignore_ct.patch (+62/-0)
mysql_syslog.patch (+124/-0)
normalize_patches.sh (+52/-0)
optimizer_fix.patch (+159/-0)
percona_support.patch (+19/-0)
query_cache_enhance.patch (+491/-0)
regenerate_patch.sh (+46/-0)
remove_fcntl_excessive_calls.patch (+82/-0)
response_time_distribution.patch (+774/-0)
series (+43/-0)
show_slave_status_nolock.patch (+114/-0)
show_temp.patch (+393/-0)
slow_extended.patch (+1243/-0)
sql_no_fcache.patch (+401/-0)
uninstall_tests.sh (+24/-0)
userstat.patch (+3343/-0)
Vadim Tkachenko (vadim-tk)
Changed in percona-server:
importance: Undecided → High
milestone: none → 5.5-20beta
Vadim Tkachenko (vadim-tk)
Changed in percona-server:
assignee: nobody → Oleg Tsarev (tsarev)
Oleg Tsarev (tsarev)
Changed in percona-server:
status: New → In Progress
Revision history for this message
Oleg Tsarev (tsarev) wrote :

Vadim,

I think you mean:
"Rename ENABLE_QUERY_RESPONSE_TIME_STATS to QUERY_RESPONSE_TIME".
This is OK, what we have same name to INFORMATION_SCHEMA.QUERY_RESPONSE_TIME?

Oleg Tsarev (tsarev)
Changed in percona-server:
status: In Progress → Fix Committed
Revision history for this message
Baron Schwartz (baron-xaprb) wrote : Re: [Bug 714884] Re: rename enable_query_response_time option in 5.5

I think that the name "query_response_time" might be too generic, and
could conflict or be confusing with additional features in the future.
 We might create many ways to measure query response time, and they
could all potentially be described as "query_response_time". I
propose "aggregate_query_response_time". (It is hard to find a good
name.)

Revision history for this message
Vadim Tkachenko (vadim-tk) wrote :

Baron,

Maybe
"query_response_time_histogram" or "query_response_time_distribution" ?

Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

Vadim, I like query_response_time_histogram.

Vadim Tkachenko (vadim-tk)
Changed in percona-server:
status: Fix Committed → Fix Released
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-464

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.