-Dbytes not seeing total bytes transferred
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
High
|
John A Meinel |
Bug Description
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I don't know what we broke in the tracking data-transferred case, but I
was just doing some testing with:
bzr branch -Dbytes bzr+ssh:
And it didn't report the number of bytes transferred. Checking in
~/.bzr.log shows that it thought there were 0 bytes transferred, which
is when it suppresses the message (though it shouldn't if you are
passing -Dbytes directly.)
I tested the same command with bzr 2.2.2 and the bytes transferred were
tracked correctly (as near as I could tell).
While the content is being transferred, it does seem to be aggregating
the number of bytes. So something between the active transport
transferring data, and the final logging of it has been broken.
I did some manual stepping back through old tags, and this broke between
bzr-2.3b1 and bzr-2.3b2.
I haven't been able to figure out what, exactly, is going on. But it
looks like the object that is getting 'report_
calls, is *not* the same object that is getting
'log_transport_
I wonder if this is the initialize() code screwing with state?
affects bzr
status confirmed
importance critical
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://
iEYEARECAAYFAk1
JoAAoNOXG4MqLhk
=M2d4
-----END PGP SIGNATURE-----
Related branches
- Martin Pool: Approve
-
Diff: 92 lines (+33/-9)3 files modifiedbzrlib/commands.py (+5/-4)
bzrlib/tests/blackbox/test_debug.py (+24/-5)
doc/en/release-notes/bzr-2.3.txt (+4/-0)
Changed in bzr: | |
status: | In Progress → Fix Released |
Some debugging. Inside the main() function in bzrlib/commands.py is where we are doing the logging. At the point where we are ready to run the command:
ret = run_bzr_ catch_errors( argv) ui.ui_factory. _progress_ view ui.text. TextProgressVie w object at 0x9ac42cc>
(pdb) bzrlib.
<bzrlib.
At the point where we are ready to print
bzrlib. ui.ui_factory. log_transport_ activity( ...) ui.ui_factory. _progress_ view ui.text. TextProgressVie w object at 0xa003f4c>
(pdb) bzrlib.
<bzrlib.
So something between when we start and when we finish is changing the _progress_view object. Note that I checked and the ui_factory object itself has not changed.