byobu disk_io script cannot handle cryptsetup, LVM, and other DM-based volumes

Bug #711373 reported by Chow Loong Jin
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

  affects ubuntu/byobu
  status triaged

In a nutshell:
% /usr/lib/byobu/disk_io
awk: cmd. line:1: fatal: cannot open file `/sys/block/cryptostuff-root/stat' for
reading (No such file or directory)

% ls /sys/block
dm-0@ dm-2@ loop0@ loop2@ loop4@ loop6@ ram0@ ram10@ ram12@ ram14@
ram2@ ram4@ ram6@ ram8@ sda@ zram1@
dm-1@ dm-3@ loop1@ loop3@ loop5@ loop7@ ram1@ ram11@ ram13@ ram15@
ram3@ ram5@ ram7@ ram9@ zram0@

% ls -l /dev/mapper
total 0
crw------- 1 root root 10, 236 2011-01-21 00:09 control
lrwxrwxrwx 1 root root 7 2011-01-21 00:09 cryptostuff -> ../dm-0
lrwxrwxrwx 1 root root 7 2011-01-21 00:09 cryptostuff-home -> ../dm-3
lrwxrwxrwx 1 root root 7 2011-01-21 00:09 cryptostuff-root -> ../dm-1
lrwxrwxrwx 1 root root 7 2011-01-21 00:09 cryptostuff-swap -> ../dm-2
lrwxrwxrwx 1 root root 7 2011-01-24 00:57 temporary-cryptsetup-15388 ->
../dm-4
lrwxrwxrwx 1 root root 7 2011-01-26 08:09 temporary-cryptsetup-31710 ->
../dm-8

Basically, resolving the symlinks down to the actual device should solve the
issue. I've attached a patch which appears to do just that.

--
Kind regards,
Loong Jin

Tags: patch

Related branches

Revision history for this message
Chow Loong Jin (hyperair) wrote :
tags: added: patch
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Awesome, thanks for the patch! I just committed the same change moments ago ;-)

Cheers!

Changed in byobu (Ubuntu):
status: Triaged → Fix Committed
importance: Undecided → Medium
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 3.29-0ubuntu1

---------------
byobu (3.29-0ubuntu1) natty; urgency=low

  [ Dustin Kirkland ]
  * usr/share/man/man1/byobu.1: document PS1 workaround, LP: #525552
  * usr/share/man/man1/byobu.1: fix minor manpage typo, add SERVICES example
  * usr/lib/byobu/wifi_quality, usr/share/man/man1/byobu.1: support overriding
    the default wireless interface, LP: #723260
  * usr/share/man/man1/byobu.1: document TERM=vt100 for Mac keyboard users,
    LP: #482623
  * usr/bin/byobu-janitor: use readlink, much more graceful
  * usr/lib/byobu/time_binary, usr/share/byobu/profiles/common,
    usr/share/man/man1/byobu.1: fixup a couple of minor issues with the binary
    clock commit
  * usr/bin/byobu-status: switch the interpreter from sh to bash; this is
    needed to support James' time_binary script, which is bash and cannot be
    simply sourced by byobu-status; if significant performance regressions
    occur, we will need to back this change out and approach it a different
    way

  [ James Hunt ]
  * etc/byobu/statusrc, usr/bin/byobu-config, usr/lib/byobu/time_binary,
    usr/share/byobu/profiles/common, usr/share/man/man1/byobu.1:
    - add support for the super-geeky-but-fun binary clock; requires
      UTF8 support in GNU Screen, LP: #705037

  [ Chow Loong Jin and Dustin Kirkland ]
  * usr/lib/byobu/disk_io: canonicalize symlinks so that disk_io works
    with raid, lvm, dm volumes, LP: #709224, #711373, #723187
 -- Dustin Kirkland <email address hidden> Wed, 23 Feb 2011 16:24:38 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.