Percona Server moved to https://jira.percona.com/projects/PS

Remove all references to autogenerated files in all our patches

Bug #700965 reported by Alexey Kopytov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Invalid
High
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.5.14-20.5
5.1
Fix Released
High
Oleg Tsarev
Percona Server moved to https://jira.percona.com/projects/PS 5.1.58-12.9
5.5
Invalid
High
Laurynas Biveinis
Percona Server moved to https://jira.percona.com/projects/PS 5.5.14-20.5
Rnt-5.1
Fix Released
Undecided
Oleg Tsarev

Bug Description

We should remove all changes in autogenerated files (such as 'configure', 'Makefile.in' and so on) from our patches. They cause a lot of headache when doing some mass editing of patches (for example, when cleaning up warnings/errors).

Related branches

lp:~laurynas-biveinis/percona-server/bug700965-5.1
Percona developers: Pending requested
Diff: 331 lines (+0/-259)
6 files modified
bugfix48929.patch (+0/-25)
innodb_show_enhancements.patch (+0/-11)
innodb_swap_builtin_plugin.patch (+0/-109)
response-time-distribution.patch (+0/-38)
show_patches.patch (+0/-22)
userstat.patch (+0/-54)
lp:~tsarev/percona-server/rnt-5.1
lp:percona-server/rnt-5.1
Revision history for this message
Stewart Smith (stewart) wrote :

I'm very surprised this hasn't horribly broken things.

Changed in percona-server:
status: New → Confirmed
importance: Undecided → High
Stewart Smith (stewart)
Changed in percona-server:
status: Confirmed → Triaged
Revision history for this message
Stewart Smith (stewart) wrote :

Is this currently actually 'In Progress'? if not, should just be Triaged

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Affected patches in 5.1:

innodb_swap_builtin_plugin.patch (configure)
show_patches.patch (sql/Makefile.in)
userstat.patch (configure)
innodb_show_enhancements.patch (Makefile.in)
bugfix48929.patch (configure)
response-time-distribution.patch (sql/Makefile.in)

Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

If the "configure.in" was patched, does the execute of "./configure" detect always the obsoleted the files and regenerate them automatically?
(I remember, at least in ancient, I met some dependency problem about regeneration the files (It might be MySQL's bug, which was already fixed))

Or we should document the procedure needed before "./configure"

Revision history for this message
Yasufumi Kinoshita (yasufumi-kinoshita) wrote :

I agree if no problem for "all environments", now.
(I mean, for example, older distribution might not have enough version of automake)

Revision history for this message
Stewart Smith (stewart) wrote : Re: [Bug 700965] Re: Remove all references to autogenerated files in all our patches

On Mon, 18 Jul 2011 08:57:57 -0000, Yasufumi Kinoshita <email address hidden> wrote:
> If the "configure.in" was patched, does the execute of "./configure" detect always the obsoleted the files and regenerate them automatically?
> (I remember, at least in ancient, I met some dependency problem about regeneration the files (It might be MySQL's bug, which was already fixed))
>
> Or we should document the procedure needed before "./configure"

With Jenkins we should be able to find out if it gets it wrong anywhere,
but I've found it usually works fine... otherwise we can add in
regeneration steps.
--
Stewart Smith

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

Some patches already do not include the generated files and thus correct re-generation is already required for correct builds.

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

5.5 is already clean (side effect of CMake).

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

In 5.1 config.h.in is also a generated file in bugfix48929.patch and userstat.patch.

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-456

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.