byobu

Add/correct some tests, handle non-vim case and fix duplicate paging

Bug #700911 reported by swalker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
Low
Unassigned
byobu (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

byobu-status
  folding commands are vim-only, perhaps the "Detailed Status Navigation" on the previous line as well

byobu-status-detail
  /usr/bin/byobu-status-detail: 28: vim: not found
 runs consecutive $PAGERs

mail
  ls: cannot access /var/spool/mail/$USER: No such file or directory

reboot_required
  ls: cannot access /var/run/reboot-required: No such file or directory
  ls: cannot access /var/run/screen/S-$USER/byobu.reload-required: No such file or directory

wifi_quality
  awk: (FILENAME=- FNR=1) fatal: division by zero attempted

Related branches

lp:byobu
lp:ubuntu/natty/byobu
Revision history for this message
swalker (sdwalker) wrote :
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Thanks for the patch!

All of these look good except the wifi one:

./usr/lib/byobu/wifi_quality
[: 32: Illegal number: 70/70

I fixed that part up.

Committed revision 1285.

Changed in byobu:
importance: Undecided → Low
status: New → Fix Committed
Changed in byobu (Ubuntu):
importance: Undecided → Low
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 3.26-0ubuntu1

---------------
byobu (3.26-0ubuntu1) natty; urgency=low

  [ Dustin Kirkland ]
  * usr/bin/byobu-reconnect-sockets, usr/lib/byobu/date,
    usr/share/byobu/keybindings/f-keys,
    usr/share/byobu/keybindings/screen-escape-keys:
    - add a ctrl-f5 keybinding for reconnecting sockets
  * usr/share/byobu/profiles/common: explicitly set deflogin on,
    LP: #525552

  [ swalker <email address hidden> ]
  * A set of fixes for LP: #700911
  * usr/bin/byobu-status, usr/bin/byobu-status-detail:
    - improve support for byobu-status-detail on systems without vim
  * usr/lib/byobu/mail: test for mail dir, avoids errors
  * usr/lib/byobu/reboot_required: test for file existence, avoids errors

  [ Dustin Kirkland + swalker <email address hidden> ]
  * usr/lib/byobu/wifi_quality: avoid potential divide by zero error
  * usr/lib/byobu/fan_speed: add support for /proc/i8k for some other
    systems' fan speeds (e.g. Dell Inspiron), LP: #700204
 -- Dustin Kirkland <email address hidden> Sun, 23 Jan 2011 16:28:45 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
swalker (sdwalker) wrote :

Not sure how useful a "0Mbps,0%" being printed is and not exiting when the bitrate/quality values are zero rather than their lengths being zero.

Revision history for this message
Dustin Kirkland  (kirkland) wrote : Re: [Bug 700911] Re: Add/correct some tests, handle non-vim case and fix duplicate paging

Hmm, well, I was doing this to be consistent with the network monitor,
which shows "^0kbps v0kbps" when network traffic is zero.

But I think I see your point...

Dustin Kirkland  (kirkland)
Changed in byobu:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.