show a different message if you are not connected to the internet

Bug #699944 reported by Danielle Foré
18
This bug affects 6 people
Affects Status Importance Assigned to Milestone
Midori Web Browser
Fix Released
Medium
Robert Roth

Bug Description

Currently, there is no distinction between not being able to find a URL and not being connected to the internet. Midori should make it clear to the user that he needs to check his network settings and the problem is not occuring inside the browser.

Related branches

Changed in midori:
importance: Undecided → Medium
Revision history for this message
Calvin B. (reflective-surface) wrote :

A solution would be perhaps ping known websites, or ones in bookmarks, if they all fail to load and are remote, then presume your system is offline.

Michael Moroni (airon90)
tags: added: message offline
Revision history for this message
Tomasz Szatkowski (szatkus) wrote :

Works for me.

Changed in midori:
status: New → Confirmed
Cris Dywan (kalikiana)
summary: - [Error] show a different message if you are not connected to the
- internet
+ show a different message if you are not connected to the internet
tags: added: error
Cris Dywan (kalikiana)
tags: added: connection internet network
Revision history for this message
Danielle Foré (danrabbit) wrote :

Bumping this report. GIO (Glib 2.32) should have an API to let us check if we're online now.

Revision history for this message
Robert Roth (evfool) wrote :

@Daniel Fore:
Any suggestions on what the different messages should look like?

As a starting point I have a branch attached which simply filters the suggestions from the current error page (check address for typos, check cable plugged in or wifi card enabled, check network setting) based on the network availability provided by glib:
* if g_network_monitor_get_network_available is false, meaning there's no default route, show the check the cable/wifi card suggestions
* if g_network_monitor_can_reach doesn't reach midori-browser.org show the check network settings suggestion
* if none of the above is true (we have a network connection AND midori-browser.org is theoretically reachable) show the check for typos suggestion.

Changed in midori:
assignee: nobody → Daniel Fore (danrabbit)
status: Confirmed → Incomplete
Revision history for this message
Danielle Foré (danrabbit) wrote :

Hey Robert,

I've created a google doc with some suggested messages so that we can make comments/edits: https://docs.google.com/document/d/1ToyM9GFw7ULJS7DX-DKYbx1Q1F1oqrsChDf0xNFBzWM/edit?usp=sharing

Revision history for this message
Robert Roth (evfool) wrote :

Hi Daniel,

I have commented some things in the doc you have shared, and have updated the branch so that it already has your texts, you can try it, to see how do you like it.

Robert Roth (evfool)
Changed in midori:
assignee: Daniel Fore (danrabbit) → Robert Roth (evfool)
status: Incomplete → In Progress
Revision history for this message
Robert Roth (evfool) wrote :

@Daniel: could you please review the strings document with the comments (Christian's and mine), and see if we can agree on the strings with the maintainer.

RabbitBot (rabbitbot-a)
Changed in midori:
status: In Progress → Fix Committed
Changed in midori:
milestone: none → 0.5.9
Cris Dywan (kalikiana)
Changed in midori:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.