recipe build for removed recipe triggers uploader exception
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Ian Booth |
Bug Description
When a recipe build has been removed since a recipe build was started the archive uploader will fall over:
OOPS-1832FTPMASTER446
Traceback (most recent call last):
File "/srv/launchpad
return func(self, *args, **kw)
File "/srv/launchpad
implicit_
File "/srv/launchpad
return func(self, *args, **kw)
File "/srv/launchpad
self.main()
File "/srv/launchpad
processor.
File "/srv/launchpad
self.
File "/srv/launchpad
build.
File "/srv/launchpad
mailer.
File "/srv/launchpad
ctrl = self.generateEm
File "/srv/launchpad
subject = self._getSubjec
File "/srv/launchpad
return self._subject_
File "/srv/launchpad
'recipe': self.build.
AttributeError: 'NoneType' object has no attribute 'name'
It should explicitly check if the recipe still exists, and otherwise discard the build.
Related branches
- Leonard Richardson (community): Approve
-
Diff: 151 lines (+80/-7)4 files modifiedlib/lp/archiveuploader/tests/test_uploadprocessor.py (+34/-0)
lib/lp/archiveuploader/uploadprocessor.py (+26/-7)
lib/lp/code/model/sourcepackagerecipebuild.py (+4/-0)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+16/-0)
summary: |
- recipe build for removed recipe trigger upload error + recipe build for removed recipe triggers uploader exception |
Changed in launchpad: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: oops |
tags: |
added: recipe removed: oops |
tags: | added: oops |
description: | updated |
Changed in launchpad: | |
importance: | High → Critical |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Ian Booth (wallyworld) |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Fixed in stable r12304 <http:// bazaar. launchpad. net/~launchpad- pqm/launchpad/ stable/ revision/ 12304>.