poppler 0.16 compatibility

Bug #696025 reported by Hanno Böck
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Poppler Python Bindings
New
Undecided
Unassigned

Bug Description

Current python-poppler won't compile with poppler 0.16:
libtool: compile: x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I/usr/include/python2.7 -pthread -DQT_SHARED -I/usr/include/pygtk-2.0 -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/libdrm -I/usr/include/qt4/QtCore -I/usr/include/poppler/glib -I/usr/include/poppler -DQT_SHARED -pthread -I/usr/include/pycairo -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng14 -I/usr/include/qt4 -I/usr/include/qt4/QtGui -I/usr/include/libdrm -I/usr/include/qt4/QtCore -O2 -march=core2 -pipe -Wall -std=c9x -fno-strict-aliasing -MT poppler_la-poppler.lo -MD -MP -MF .deps/poppler_la-poppler.Tpo -c poppler.c -fPIC -DPIC -o .libs/poppler_la-poppler.o
poppler.c: In Funktion »_wrap_poppler_page_get_text«:
poppler.c:3598:5: Fehler: zu viele Argumente für Funktion »poppler_page_get_text«

Attached patch is taken from madriva and will fix it:
http://permalink.gmane.org/gmane.linux.mandrake.cooker.commits/254163

Revision history for this message
Hanno Böck (hanno-hboeck) wrote :
Revision history for this message
Pino Toscano (pinotree) wrote :

While the patch is correct, theorically this changes the naming wrt the counterpart functions in poppler-glib, see the upstream commit:
http://cgit.freedesktop.org/poppler/poppler/commit/?id=b257428150e2c13dcc24fd8f75e4ee2c679ab41
So renaming the functions, while ideal to match poppler-glib, would just break users of poppler-python (which will break anyway again with poppler 0.18).

Revision history for this message
Matthias Kilian (kili-p) wrote :

Oh, and the patch is *not* correct. poppler_page_get_selected_text() can't be used as a simple replacement for the former poppler_page_get_text() because it also has changed semantics.

Revision history for this message
Jakub Wilk (jwilk) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.