Distribution series hardcoded for installing Fluendo plug-in
Bug #693536 reported by
dobey
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One for Rhythmbox |
Fix Released
|
Medium
|
dobey | ||
libubuntuone |
Fix Released
|
Medium
|
dobey | ||
libubuntuone (Ubuntu) |
Fix Released
|
Medium
|
dobey | ||
rhythmbox-ubuntuone-music-store (Ubuntu) |
Fix Released
|
Medium
|
dobey |
Bug Description
The series information for activating the partner repository and installing the MP3 plug-in, is hardcoded. This should be done in an abstract way so that it will just work no matter what version of Ubuntu the plug-in is installed on. It would also be nice to abstract this even further so that it could be used on systems other than Ubuntu.
Related branches
lp:~arvindsraj-deactivatedaccount/rhythmbox-ubuntuone/hardcoding-version-removed
Rejected
for merging
into
lp:rhythmbox-ubuntuone
- dobey (community): Disapprove
-
Diff: 34 lines (+12/-2)1 file modifiedumusicstore/MusicStoreWidget.py (+12/-2)
lp:~dobey/libubuntuone/codec-installer
- Alejandro J. Cura (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 1078 lines (+921/-6)6 files modifiedconfigure.ac (+1/-1)
data/Makefile.am (+1/-0)
libubuntuone/Makefile.am (+2/-0)
libubuntuone/u1-codec-installer.c (+650/-0)
libubuntuone/u1-codec-installer.h (+68/-0)
libubuntuone/u1-music-store.c (+199/-5)
lp:~dobey/rhythmbox-ubuntuone/libu1-mp3-install
- Eric Casteleijn (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 432 lines (+33/-226)5 files modifiedgst/__init__.py (+0/-14)
gst/pbutils.py (+0/-6)
rb.py (+3/-0)
umusicstore/MusicStoreWidget.py (+23/-200)
umusicstore/__init__.py (+7/-6)
Changed in rhythmbox-ubuntuone-music-store (Ubuntu): | |
milestone: | none → ubuntu-11.04-beta |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in rhythmbox-ubuntuone-music-store (Ubuntu): | |
assignee: | nobody → Arvind S Raj (arvindsraj) |
Changed in rhythmbox-ubuntuone-music-store: | |
assignee: | nobody → Arvind S Raj (arvindsraj) |
tags: | added: u1-natty-beta |
Changed in rhythmbox-ubuntuone-music-store (Ubuntu): | |
milestone: | ubuntu-11.04-beta-1 → ubuntu-11.04-beta-2 |
Changed in libubuntuone (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → Medium |
assignee: | nobody → Rodney Dawes (dobey) |
milestone: | none → ubuntu-11.04-beta-2 |
Changed in rhythmbox-ubuntuone-music-store: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in libubuntuone: | |
status: | In Progress → Fix Committed |
Changed in rhythmbox-ubuntuone-music-store: | |
status: | Confirmed → Fix Committed |
Changed in rhythmbox-ubuntuone-music-store: | |
assignee: | Arvind S Raj (arvindsraj) → Rodney Dawes (dobey) |
Changed in rhythmbox-ubuntuone-music-store (Ubuntu): | |
assignee: | Arvind S Raj (arvindsraj) → Rodney Dawes (dobey) |
Changed in libubuntuone: | |
status: | Fix Committed → Fix Released |
Changed in rhythmbox-ubuntuone-music-store: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
A solution to this would be to use the code of lsb_release to determine the codename. After determining the codename,
PARTNER_ LIST = "canonical- partner- maverick. list" (line 59 in umusicstore/ MusicStoreWidge t.py)
PARTNER_ LIST = "canonical- partner- " + codename + ".list"
dist= "maverick" (line 439 in umusicstore/ MusicStoreWidge t.py)
dist= codename.
would change to
and
would change to
Or is there any better alternative?