file conflict in mo files and license issue

Bug #688601 reported by Kyle Nitzsche
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gufw
Fix Released
Undecided
Unassigned
gui-ufw (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Hi,

This package has a couple issues:
 * Its translation files (the gufw.mo files, one for each language) are installed into /usr/share/locale-langpack/... However, this location is reserved for Ubuntu language pack .mo files. If this pkg ever moves into Ubuntu Main (which means language packs would install gufw.mo files into /usr/share/locale-langpack/... ), there would be a file conflict (two binary pkgs trying to install the same file). This would prevent installation of whichever pkg was installed second.
   - FIX: This can be fixed by releasing a new verson of the package that installs the .mo files into the package's location: /usr/share/locale/...
 * The source pkg in the archives contains .mo files instead of .po files. The proper appoach is for the src package to contain .po files in a directory named po/. that directory should to include a file named POTFILES.in that lists the path to every file with translatable messages. (Doing this enables intltool.) Then the .mo files need to be created on each build of the pkg. (Note, containing .mo files in the src package may be a license violation).

Cheers,
Kyle

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi,

I pushed a branch that should fix these problems. https://code.launchpad.net/~knitzsche/gui-ufw/i18n-l10n-fixes

The branch implements python-distutils-extra for i18n support.

With this branch, there is a po/ directory that contains LANG_CODE.po files and a POTFILES.in file.

The po files were downloaded from LP on 17 Dec. Here's the link: http://launchpadlibrarian.net/60806909/launchpad-export.tar.gz
(Not sure how long that link will be good.)

Note that the branch also provides completed translations for zh_CN (Chinese/Simplified).

When you build the pkg, it creates gufw.mo files for each locale. These are automatically installed in the correct location: /usr/share/locale/LANG_CODE/

You can update translations by replacing the target po file (or po files) and running (from src pkg root dir):
'./setup.py build_i18n -m'

The source pkg still contains a locale-langpack/ directory, but I believe this is no longer referenced or needed and it should be deleted. (This is the directory that contains the .mo files, which should not be included in a source package.)

See merger proposal 44278.

Cheers,
Kyle

Revision history for this message
Vadim Peretokin (vperetokin) wrote : Re: [Gufw-developers] [Bug 688601] Re: file conflict in mo files and license issue

Thanks a ton! Marcos will go over it when he gets a chance.

On 2010-12-20 3:42 PM, "Kyle Nitzsche" <email address hidden> wrote:

Hi,

I pushed a branch that should fix these problems.
https://code.launchpad.net/~knitzsche/gui-ufw/i18n-l10n-fixes

The branch implements python-distutils-extra for i18n support.

With this branch, there is a po/ directory that contains LANG_CODE.po
files and a POTFILES.in file.

The po files were downloaded from LP on 17 Dec. Here's the link:
http://launchpadlibrarian.net/60806909/launchpad-export.tar.gz
(Not sure how long that link will be good.)

Note that the branch also provides completed translations for zh_CN
(Chinese/Simplified).

When you build the pkg, it creates gufw.mo files for each locale. These
are automatically installed in the correct location:
/usr/share/locale/LANG_CODE/

You can update translations by replacing the target po file (or po files)
and running (from src pkg root dir):
'./setup.py build_i18n -m'

The source pkg still contains a locale-langpack/ directory, but I
believe this is no longer referenced or needed and it should be deleted.
(This is the directory that contains the .mo files, which should not be
included in a source package.)

See merger proposal 44278.

Cheers,
Kyle

--
You received this bug notification because you are a member of Gufw
Developers, which is subscr...

Revision history for this message
costales (costales) wrote :

Hi! I just arrived from a long travel ;) I'll reply and review in a short time :)

costales (costales)
Changed in gui-ufw (Ubuntu):
status: New → Confirmed
Changed in gui-ufw:
status: New → In Progress
Changed in gui-ufw (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
costales (costales) wrote :

Hi Kyle! First: Thanks very much for the code!!!
I just reviewed your change and you used an obsolete branch: http://acurti.es/PTm The code for the actual branch changed a lot, because I migrated from Glade to GTKbuilder, from gksu application to DBus service, and more things.
I will implement for the actual branch: http://acurti.es/OTm
Thanks very much for the bug and the code ;) Cheers!

Revision history for this message
costales (costales) wrote :

@kyle: "The po files were downloaded from LP on 17 Dec."
Hi! If you're using Gufw with that .po files, a lot of strings will be missing, because the interface change a little and it has a 30% of new strings.

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi,

I used the source pkg in Maverick universe (not the trunk) and completed translations for Chinese/Simplified - so all is well on my end.

Cheers,
Kyle

costales (costales)
Changed in gui-ufw:
status: In Progress → Fix Committed
Changed in gui-ufw (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gui-ufw - 11.04.2-0ubuntu1

---------------
gui-ufw (11.04.2-0ubuntu1) natty; urgency=low

  * New upstream release (LP: #688601, #710957, #726821).
  * debian/rules: add override_dh_auto_clean target to remove generated
    mo dir.
  * debian/control: modify debhelper (>= 7) to debhelper (>= 7.0.50~).
 -- Devid Antonio Filoni <email address hidden> Mon, 28 Feb 2011 23:09:45 +0100

Changed in gui-ufw (Ubuntu):
status: Fix Committed → Fix Released
costales (costales)
Changed in gui-ufw:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.