framebuffer: consolidate calls to udevadm settle

Bug #687588 reported by dann frazier
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
Low
Unassigned
initramfs-tools (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: initramfs-tools

In scripts/init-top/framebuffer we have this code:

 if [ -n "${FB}" ]; then
  # Some framebuffer devices need character devices :-/
  udevadm settle
  MODPROBE_OPTIONS=-q modprobe ${FB} ${OPTS}
  # Wait for the framebuffer devices to be ready
  udevadm settle
 else
  # If we have no graphics devices yet, wait for udev to settle
  [ -d /sys/class/graphics/fbcon ] || udevadm settle
  [ -d /sys/class/graphics/fb0 ] || udevadm settle
  [ -d /sys/class/drm/card0 ] || udevadm settle
 fi

The else clause here appears to be called even on a headless system, which would presumably cause us to call 'udevadm settle' 3 times. Sure, it should be fast (unless there's a bug, which in my case there is), but not as fast as just calling it once. Since I don't see any functional value in calling it each time, I propose we consolidate to one.

Revision history for this message
dann frazier (dannf) wrote :

Suggested patch.

Colin Watson (cjwatson)
Changed in initramfs-tools (Ubuntu):
status: New → Fix Committed
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package initramfs-tools - 0.98.1ubuntu9

---------------
initramfs-tools (0.98.1ubuntu9) natty; urgency=low

  [ dann frazier ]
  * framebuffer: consolidate calls to 'udevadm settle' (LP: #687588).
 -- Colin Watson <email address hidden> Thu, 09 Dec 2010 12:28:27 +0000

Changed in initramfs-tools (Ubuntu):
status: Fix Committed → Fix Released
Steve Magoun (smagoun)
Changed in oem-priority:
importance: Undecided → Low
status: New → Fix Committed
Chris Van Hoof (vanhoof)
Changed in oem-priority:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.