Ubuntu
vm-builder package

vmbuilder fails to unmount cdrom cleanly

Bug #685258 reported by Neil Wilson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
vm-builder (Ubuntu)
Fix Released
Low
Serge Hallyn

Bug Description

When using a cd image for building machines, vmbuilder always leaves the loop device setup.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: python-vm-builder 0.12.4-0ubuntu1.1
ProcVersionSignature: Ubuntu 2.6.35-23.41-generic 2.6.35.7
Uname: Linux 2.6.35-23-generic x86_64
Architecture: amd64
Date: Sat Dec 4 18:51:35 2010
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_GB.utf8
 SHELL=/bin/bash
SourcePackage: vm-builder

Related branches

lp:~serge-hallyn/vmbuilder/cleanup-iso
Serge Hallyn: Approve
Diff: 20 lines (+2/-1)
1 file modified
VMBuilder/distro.py (+2/-1)
lp:ubuntu/natty/vm-builder
Revision history for this message
Neil Wilson (neil-aldur) wrote :
Revision history for this message
Neil Wilson (neil-aldur) wrote :

The cleanup on exception was commented out.

If there isn't a reason for that then the attached patch runs cleanup on BaseException (to catch interrupts) and after post_install, which removes the iso mount.

Brian Murray (brian-murray)
tags: added: patch
Serge Hallyn (serge-hallyn)
Changed in vm-builder (Ubuntu):
importance: Undecided → Low
assignee: nobody → Serge Hallyn (serge-hallyn)
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Hi Neil, thanks for reporting this bug. Can you give me a sample vmbuilder
invocation using a cd?

Changed in vm-builder (Ubuntu):
status: New → Incomplete
Revision history for this message
Neil Wilson (neil-aldur) wrote :

Sure. I've attached the build script I use.

Changed in vm-builder (Ubuntu):
status: Incomplete → Confirmed
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Simple test certainly seems to confirm that this patch works.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Neil,

thanks for the patch. I'll work it into the package.

Serge Hallyn (serge-hallyn)
Changed in vm-builder (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Hi Neil,

could you tell me if you have signed the copyright assignment agreement (http://www.canonical.com/contributors)?

Revision history for this message
Neil Wilson (neil-aldur) wrote : Re: [Bug 685258] Re: vmbuilder fails to unmount cdrom cleanly

Yes. Sent across now.

On 13 December 2010 17:56, Serge Hallyn <email address hidden> wrote:
> Hi Neil,
>
> could you tell me if you have signed the copyright assignment agreement
> (http://www.canonical.com/contributors)?
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/685258
>
> Title:
>  vmbuilder fails to unmount cdrom cleanly
>

--
Neil Wilson

Serge Hallyn (serge-hallyn)
Changed in vm-builder (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package vm-builder - 0.12.4+bzr460

---------------
vm-builder (0.12.4+bzr460) natty; urgency=low

  * clean up on failure to unmount and release loop devices (lp: #685258)
 -- Serge Hallyn <email address hidden> Thu, 14 Dec 2010 12:28:21 -0600

Changed in vm-builder (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.