fix for LP: #672965 breaks returns for AJ and Synapse

Bug #683146 reported by Seif Lotfy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Fix Released
Critical
Markus Korn

Bug Description

running revision 1639+ breaks returns for find_events when called from AJ and Synapse.
I always get:
DEBUG:zeitgeist.engine:Found 0 events IDs in 0.007377s
This can be fixed by just making the queries to use the index.
So just remove the + from infront of the timestamp
---
if min_time != 0:
 where.add("+timestamp >= ?", min_time)
if max_time != sys.maxint:
 where.add("+timestamp <= ?", max_time)
---

Related branches

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote : Re: [Zeitgeist] [Bug 683146] [NEW] fix for LP: #672965 breaks returns for AJ and Synapse

This is critical of course. But I am really baffled that not using the
indexes can cause the query to fail altogether. This should not affect
the result set in any way - only the execution time.

I'd really like to see a unit test that catches this error.

Revision history for this message
Seif Lotfy (seif) wrote :

Mikkel can you try it with GAJ
Tell me if it works for you please :)

On Tue, Nov 30, 2010 at 4:07 PM, Mikkel Kamstrup Erlandsen <
<email address hidden>> wrote:

> This is critical of course. But I am really baffled that not using the
> indexes can cause the query to fail altogether. This should not affect
> the result set in any way - only the execution time.
>
> I'd really like to see a unit test that catches this error.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~zeitgeist
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~zeitgeist
> More help : https://help.launchpad.net/ListHelp
>

--
This is me doing some advertisement for my blog http://seilo.geekyogre.com

Markus Korn (thekorn)
Changed in zeitgeist:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Markus Korn (thekorn)
Markus Korn (thekorn)
Changed in zeitgeist:
status: Triaged → Fix Committed
Seif Lotfy (seif)
Changed in zeitgeist:
milestone: none → 0.7.0
Seif Lotfy (seif)
Changed in zeitgeist:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.