Affected people from duplicates aren't included in the master bug's affected count

Given that the number of subscribers from duplicates is taken into account when bug heat is calculated it seems odd that we don't update the subscriber count on the page, too.

This looks like we show the wrong attribute (users_affected, not users_affected_count_with_dupes) in templates - so a shallow thing to change /code wise/ - but it will need some performance checks to make sure it doesn't regress anything.

The thing to change is in lib/lp/bugs/browser/bugtask.py.

This is a special case of bug 343110, but perhaps easy to fix separately.

> This looks like we show the wrong attribute (users_affected, not users_affected_count_with_dupes) in templates - so a shallow thing to change /code wise/

I looked at this in the code, and there is indeed a possible snag. users_affected_count is stored on in a column on the bug, but users_affected_count_with_dupes is calculated by finding all the users and counting them, so there's at least a possible performance problem there. We can either see if it is fast enough to query it, or we could add another cache in the database.

Adding them up, whether done at update time or query time, ought to take into account that if person A is affected by bugs X and Y that end up both being marked as dupes of Z, that's only one person.

... if we later want to sort by total affected users, across all dupes, and it seems to me we would, then that may only be feasible to do if it's stored in the bug table.

Fixed in stable r14292 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14292>.

The count is higher on qas and it's not timing out.

  tags qa-ok -qa-needstesting

Ok, thanks guys.
Fabio

Dear Friends,

While it may be that the the affected counter rises, it still says "does it affect you too?".

So I was thinking for a long time, even after the date when this fix was released that this isn't fixed yet.

So... Is it really fixed :) ?

No, really, I trust what you say- that it is fixed - but what about the UI? Shouldn't the fact the it counts my "affect" from the duplicate be expressed in the UI as "This bug affects you and X more people"?

Thanks and Blessings,
Shahar

@Shahar, there's an edge case here:

bug X is a dupe of bug Y
they have independent lists of affected users
so if they're un-duped or re-duped, you can still see who was affected by each of them
but, we show the total count on Y

So there is a slightly confusing, but logical, case where you are included in the count on Y but you can also say whether it includes you or not. Being affected by the master, if you're affected by a dupe, won't increase the master's total count, but it will affect what happens if they're ever un-duped.

The ui could be improved but I don't think it's important.

Dear Martin,

Thank you for the clarification. I wasn't sure, really.

I, for one, was confused, thinking that I should mark the master as affecting me.

So I reported as Bug #973228.

Thanks and Blessings,
Shahar