authentication files for private ppas being written out with overly restrictive permissions
Bug #676738 reported by
Michael Barnett
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Jelmer Vernooij | ||
Bug Description
.htpasswd files are now being written out with 0600 permissions instead of 0644. This breaks authentication as the process that verifies access is no longer able to open the access file to check a user's credentials. I have verified that this occurs when a subscription is altered. I did not check to see if there is any different behaviour when the subscription is initially set up. (I don't believe there would be, but i include this for completeness.)
Related branches
lp:~wallyworld/launchpad/htpasswd-access-permissions
- Jelmer Vernooij (community): Approve
-
Diff: 23 lines (+5/-1)1 file modifiedlib/lp/archivepublisher/htaccess.py (+5/-1)
| Changed in soyuz: | |
| importance: | Undecided → Critical |
Revision history for this message
| Ian Booth (wallyworld) wrote | #1 |
| Changed in soyuz: | |
| status: | New → Triaged |
| assignee: | nobody → Jelmer Vernooij (jelmer) |
Revision history for this message
| Robert Collins (lifeless) wrote | #2 |
| Changed in soyuz: | |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #3 |
| Changed in soyuz: | |
| milestone: | none → 10.12 |
| tags: | added: qa-needstesting |
| Changed in soyuz: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in soyuz: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
A cowboy has been deployed - see
https:/
A better longer term solution may be required due to the fact that the reason for the code being the way it is is non obvious and the change which broke stuff didn't look out of place.