credentials should not be cleared if ping wasn't made due to empty ping url
Bug #676679 reported by
Natalia Bidart
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu Single Sign On Client |
Fix Released
|
High
|
Natalia Bidart | ||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
High
|
Natalia Bidart | ||
Bug Description
Right now, credentials are cleared after creating them if the ping url is None. This is cause by this piece of code:
197 status = self._ping_
198 if status is None:
199 yield self.clear_
we should check if status is None and if ping url was defined.
Related branches
lp:~nataliabidart/ubuntu-sso-client/ping-url-can-be-none
- dobey (community): Approve
- Chad Miller (community): Approve
- Alejandro J. Cura: Pending requested
-
Diff: 99 lines (+44/-24)2 files modifiedubuntu_sso/credentials.py (+27/-24)
ubuntu_sso/tests/test_credentials.py (+17/-0)
| Changed in ubuntu-sso-client: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| tags: | added: desktop+ u1-natty |
| Changed in ubuntu-sso-client: | |
| status: | Triaged → In Progress |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | New → Fix Released |
| importance: | Undecided → High |
| assignee: | nobody → Naty Bidart (nataliabidart) |
| Changed in ubuntu-sso-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
