Launchpad itself

BugTaskSet.getAssignedMilestonesFromSearch() can call BugTaskSet._search() directly and retrieve the milestones with one SQL query instead of two

Bug #675595 reported by Abel Deuring
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Abel Deuring
Launchpad itself 10.12

Bug Description

At present, BugTaskSet.getAssignedMilestonesFromSearch() calls BugTaskSet.serach() in order to retrieve milestone IDs; these IDs are then used to retrieve the milestone objects in another query.

BugTaskSet._search() allows us to prejoin and retrieve Milestone directly in the first query.

Tags: lp-bugs qa-ok

Related branches

lp:~adeuring/launchpad/bug-675595
Graham Binns (community): Approve (code)
Diff: 434 lines (+183/-22)
7 files modified
lib/lp/bugs/interfaces/bugtarget.py (+6/-3)
lib/lp/bugs/interfaces/bugtask.py (+11/-7)
lib/lp/bugs/model/bugtarget.py (+4/-4)
lib/lp/bugs/model/bugtask.py (+10/-2)
lib/lp/bugs/tests/test_bugtarget.py (+108/-1)
lib/lp/bugs/tests/test_bugtask_search.py (+37/-2)
lib/lp/registry/model/person.py (+7/-3)
lp:~adeuring/launchpad/bug-675595-2
Māris Fogels (community): Approve
Diff: 565 lines (+200/-119)
9 files modified
lib/canonical/launchpad/systemhomes.py (+7/-4)
lib/lp/bugs/browser/bugtask.py (+2/-2)
lib/lp/bugs/browser/tests/test_buglisting.py (+26/-0)
lib/lp/bugs/doc/milestones-from-bugtask-search.txt (+0/-54)
lib/lp/bugs/interfaces/bugtask.py (+0/-7)
lib/lp/bugs/interfaces/malone.py (+1/-1)
lib/lp/bugs/model/bugtask.py (+0/-38)
lib/lp/registry/browser/person.py (+26/-12)
lib/lp/registry/browser/tests/test_person_view.py (+138/-1)
Deryck Hodge (deryck)
Changed in malone:
importance: Undecided → High
Revision history for this message
Launchpad QA Bot (lpqabot) wrote : Bug fixed by a commit

Fixed in stable r11973 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/11973>.

Changed in malone:
milestone: none → 10.12
tags: added: qa-needstesting
Changed in malone:
status: In Progress → Fix Committed
Abel Deuring (adeuring)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.