ZeitgeistEngine.get_events(rows=x) is broken
Bug #673922 reported by
Markus Korn
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zeitgeist Framework |
Fix Released
|
Undecided
|
Seif Lotfy | ||
Bug Description
If one hands over a list of rows instead of ids to the method, get_events will fail with a TypeError. The reason is simple: ids will become a generator (line 174) and in line 183 there is a len(ids) call, which is undefined for generators.
This can be solved by either fixing the code, or removing the rows argument, as a short grep through the zeitgeist source and testsuite shows that we are not using this argument at all.
Related branches
lp:~seif/zeitgeist/fix-673922
- Markus Korn: Approve
-
Diff: 33 lines (+6/-9)1 file modified_zeitgeist/engine/main.py (+6/-9)
Revision history for this message
| Seif Lotfy (seif) wrote | #1 |
| Changed in zeitgeist: | |
| assignee: | nobody → Seif Lotfy (seif) |
| status: | New → Confirmed |
| milestone: | none → 0.7.0 |
| Changed in zeitgeist: | |
| status: | Confirmed → Fix Committed |
| Changed in zeitgeist: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Since we are not using it I suggest removing it... What do you think?