Thunderbird Indicator 1.5.3 doesn't recognize Subfolders

I am using Indicator 1.1 with Thunderbird 3.1.7 and new messages that get filtered to go to non-INBOX folders do not get reported.

I did some debugging and noticed that checkFolder() in overlay.js does not recognise my mail folders as safe folders.

Looking at the flag definitions for folders at http://mxr.mozilla.org/mozilla/source/mailnews/base/public/nsMsgFolderFlags.idl

I can see that mail folders should be flagged 0x00000004, upon doing some checks I can see that mine also are flagged in this way.

I have attached a diff of the changes I made to get notifications working for other folders.

Kind Regards

Thanks for your fix, I have committed it to trunk and it'll be in the new version.

This is a regression. The correct behavior is for libnotify-mozilla to only check for new messages in folders that thunderbird watches for new messages (folder properties / when getting new messages ...). If a user doesn't care enough about a folder to have thunderbird check it for new messages, they probably won't want to be notified about them either. In particular, this change leads to notifications for spam -- the last thing that anyone would want.

hmm, ok i get your point, BUT shouldn't it be automatically activated for imap folders that one subscribed to and automatically deactivated for ALL spam folders?

i think that would be a much "better" behaviour for rookies like me ;-)

@Tom I was not aware there was an option to mark a folder as watched when I submitted a fix. I will take a look at this.

so i think this is the best proof that it isn't already clear that one has to manually activate the watched subfolders...

@Tom My understanding is that if a folder is not checked for new messages, Thunderbird would not download new messages for that folder from the server. In this way, if Thunderbird does not receive new messages, no notifications can appear anyway. Is this not the case?

It is not possible to mark, for example, a POP3 folder or subfolder as watched for new messages. Messages that appear there are populated by filters/rules inside Thunderbird.

I have done some experiments with an IMAP account and I can see that regardless of whether I select a folder to be "checked for new messages", Thunderbird will download new messages for that folder anyway (Maybe something to do with push?), in this way the code I submitted will ignore the "checked for new messages" option and display a notification if the Thunderbird Libnotify option is disabled for "Display notifications only for Inbox".

For Imap accounts, this "checked for new messages" option seems like one way of selecting which mailboxes you want notifications for, however, for POP users, that is not an option.

@Ruben Would you be able to rollback that code I submitted? I will look into a fix that caters for both POP and IMAP users.