Mixxx

Support 45 rpm vinyl mode

Bug #672758 reported by RAFFI TEA
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Wishlist
Owen Williams
1.10
Fix Released
Wishlist
Owen Williams
Mixxx 1.10.0

Bug Description

Since Owen's branch contains xwax 0.8 it is possible to support 45 rpm.

Related branches

lp:~ywwg/mixxx/features_xwax2
RJ Skerry-Ryan: Approve
Diff: 3843 lines (+1680/-472) (has conflicts)
57 files modified
mixxx/build/depends.py (+3/-0)
mixxx/lib/xwax/timecoder.c (+1/-1)
mixxx/lib/xwax/timecoder_win32.cpp (+1/-1)
mixxx/src/cachingreader.cpp (+163/-145)
mixxx/src/cachingreader.h (+79/-74)
mixxx/src/dlgprefnovinyldlg.ui (+23/-0)
mixxx/src/dlgprefvinyl.cpp (+3/-0)
mixxx/src/dlgprefvinyldlg.ui (+7/-0)
mixxx/src/engine/enginebuffer.cpp (+5/-9)
mixxx/src/engine/enginebufferscalelinear.cpp (+0/-10)
mixxx/src/engine/enginebufferscalest.h (+5/-5)
mixxx/src/engine/enginedeck.cpp (+1/-2)
mixxx/src/engine/enginemaster.cpp (+11/-2)
mixxx/src/engine/enginemaster.h (+2/-0)
mixxx/src/engine/enginevinylsoundemu.cpp (+37/-25)
mixxx/src/engine/enginevinylsoundemu.h (+6/-1)
mixxx/src/engine/engineworkerscheduler.cpp (+25/-11)
mixxx/src/engine/engineworkerscheduler.h (+21/-6)
mixxx/src/engine/readaheadmanager.cpp (+12/-7)
mixxx/src/engine/readaheadmanager.h (+2/-1)
mixxx/src/engine/syncworker.cpp (+25/-0)
mixxx/src/engine/syncworker.h (+20/-0)
mixxx/src/engine/vinylcontrolcontrol.cpp (+6/-0)
mixxx/src/engine/vinylcontrolcontrol.h (+2/-0)
mixxx/src/library/basesqltablemodel.cpp (+85/-0)
mixxx/src/library/basetrackcache.cpp (+15/-2)
mixxx/src/library/dao/trackdao.cpp (+3/-1)
mixxx/src/library/itunes/itunesfeature.cpp (+45/-20)
mixxx/src/library/preparelibrarytablemodel.cpp (+5/-1)
mixxx/src/library/rhythmbox/rhythmboxfeature.cpp (+1/-1)
mixxx/src/library/traktor/traktorfeature.cpp (+1/-1)
mixxx/src/mixxx.cpp (+10/-35)
mixxx/src/skin/legacyskinparser.cpp (+4/-2)
mixxx/src/skin/legacyskinparser.h (+3/-1)
mixxx/src/skin/skinloader.cpp (+7/-1)
mixxx/src/skin/skinloader.h (+2/-1)
mixxx/src/soundmanager.cpp (+1/-9)
mixxx/src/soundmanager.h (+0/-2)
mixxx/src/track/beatfactory.cpp (+4/-5)
mixxx/src/trackinfoobject.cpp (+11/-1)
mixxx/src/trackinfoobject.h (+4/-0)
mixxx/src/util/fifo.h (+44/-0)
mixxx/src/util/pa_memorybarrier.h (+128/-0)
mixxx/src/util/pa_ringbuffer.c (+238/-0)
mixxx/src/util/pa_ringbuffer.h (+233/-0)
mixxx/src/vinylcontrol/vinylcontrol.cpp (+15/-2)
mixxx/src/vinylcontrol/vinylcontrol.h (+6/-1)
mixxx/src/vinylcontrol/vinylcontrolmanager.cpp (+17/-6)
mixxx/src/vinylcontrol/vinylcontrolmanager.h (+1/-0)
mixxx/src/vinylcontrol/vinylcontrolsignalwidget.cpp (+1/-1)
mixxx/src/vinylcontrol/vinylcontrolxwax.cpp (+118/-61)
mixxx/src/vinylcontrol/vinylcontrolxwax.h (+2/-1)
mixxx/src/waveform/waveformrenderer.cpp (+24/-1)
mixxx/src/waveform/waveformrenderer.h (+2/-1)
mixxx/src/widget/wspinny.cpp (+160/-10)
mixxx/src/widget/wspinny.h (+25/-1)
mixxx/src/widget/wtracktableview.cpp (+5/-4)
RJ Skerry-Ryan: Pending requested
Diff: 1496 lines (+492/-161) (has conflicts)
28 files modified
mixxx/lib/xwax/timecoder.c (+1/-1)
mixxx/lib/xwax/timecoder_win32.cpp (+1/-1)
mixxx/src/dlgprefnovinyldlg.ui (+67/-0)
mixxx/src/dlgprefvinyl.cpp (+3/-0)
mixxx/src/dlgprefvinyldlg.ui (+7/-0)
mixxx/src/engine/enginebuffer.cpp (+3/-0)
mixxx/src/engine/enginebufferscalelinear.cpp (+0/-10)
mixxx/src/engine/enginedeck.cpp (+1/-2)
mixxx/src/engine/enginevinylsoundemu.cpp (+29/-25)
mixxx/src/engine/enginevinylsoundemu.h (+1/-1)
mixxx/src/engine/vinylcontrolcontrol.cpp (+6/-0)
mixxx/src/engine/vinylcontrolcontrol.h (+2/-0)
mixxx/src/mixxx.cpp (+9/-35)
mixxx/src/skin/legacyskinparser.cpp (+4/-2)
mixxx/src/skin/legacyskinparser.h (+3/-1)
mixxx/src/skin/skinloader.cpp (+4/-2)
mixxx/src/skin/skinloader.h (+2/-1)
mixxx/src/soundmanager.cpp (+1/-0)
mixxx/src/vinylcontrol/vinylcontrol.cpp (+15/-2)
mixxx/src/vinylcontrol/vinylcontrol.h (+6/-1)
mixxx/src/vinylcontrol/vinylcontrolmanager.cpp (+2/-6)
mixxx/src/vinylcontrol/vinylcontrolsignalwidget.cpp (+1/-1)
mixxx/src/vinylcontrol/vinylcontrolxwax.cpp (+103/-57)
mixxx/src/vinylcontrol/vinylcontrolxwax.h (+1/-0)
mixxx/src/waveform/waveformrenderer.cpp (+24/-1)
mixxx/src/waveform/waveformrenderer.h (+2/-1)
mixxx/src/widget/wspinny.cpp (+169/-10)
mixxx/src/widget/wspinny.h (+25/-1)
RAFFI TEA (raffitea)
Changed in mixxx:
importance: Undecided → Wishlist
William Good (bkgood)
Changed in mixxx:
status: New → Confirmed
Revision history for this message
RAFFI TEA (raffitea) wrote :

I assign Owen the bug. Maybe he can realize an implementation (if he likes to).

Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
Revision history for this message
Owen Williams (ywwg) wrote :

yeah this is an easy thing to do. Since this is really just a preference change, I'll also support different types of vinyl on each deck.

Changed in mixxx:
status: Confirmed → In Progress
Revision history for this message
Sean M. Pappalardo (pegasus-renegadetech) wrote :

Wow diff vinyls on each deck would be awesome...and a world first! I don't think that's ever been done!

Revision history for this message
RAFFI TEA (raffitea) wrote :

Thanks Owen!

45 RPM might be very useful especially in 'pass-through' mode.

Revision history for this message
Owen Williams (ywwg) wrote :

Pass-through mode literally passes through the input audio, so it's actually a separate feature from vinyl control. ie, even if it's the mac app store version with no xwax, input passthrough will still work. As such, there's no need to have special support for 45 vs 33 passthrough.

I'm not sure different vinyl is a first... I swear I've seen serato djs using side A on one deck and side B on the other.

But it would be a fun demo to have traktor on one and serato on the other :)

RAFFI TEA (raffitea)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5642

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.