backgroundcolor left pane does not match GTK Theme color

Bug #669263 reported by m038
34
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Shotwell
Fix Released
Unknown
shotwell (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: shotwell

The backgroundcolor of the left pane (where the tags and events are listed), does not match the backgroundcolor set with the GTK Theme. The text however does, this causes an unusable contrast with the Theme i selected.

I included a screenshot of the Shotwell application with the occuring inconvenience. In the middle i have included a slice of how my Nautilus looks like with my current GTK Theme.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: shotwell 0.7.2-0ubuntu2
ProcVersionSignature: Ubuntu 2.6.35-22.35-generic 2.6.35.4
Uname: Linux 2.6.35-22-generic x86_64
NonfreeKernelModules: nvidia wl
Architecture: amd64
Date: Sun Oct 31 23:56:47 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release amd64 (20101007)
ProcEnviron:
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: shotwell

Related branches

Revision history for this message
m038 (m-gorinskat) wrote :
summary: - backgoundcolor left pane does not match GTK Theme color
+ backgroundcolor left pane does not match GTK Theme color
Revision history for this message
dazza5000 (darran-kelinske) wrote :

I have reproduced this. To repro change the background window color of your theme. Most windows take this, however, the shotwell window does not appear to be honoring the change.

Changed in shotwell (Ubuntu):
status: New → Confirmed
Revision history for this message
Adam Dingle (adam-yorba) wrote :

Thanks for the bug report. I can reproduce this too. I thought we had fixed this (see http://trac.yorba.org/ticket/2483), but that fix seems to be incomplete. I've reopened that ticket and we'll readdress this for Shotwell 0.8.

Changed in shotwell:
status: Unknown → New
Omer Akram (om26er)
Changed in shotwell (Ubuntu):
importance: Undecided → Low
status: Confirmed → Triaged
Changed in shotwell:
status: New → Confirmed
Changed in shotwell:
status: Confirmed → Fix Released
Revision history for this message
Omer Akram (om26er) wrote :

shotwell 0.8.1 is now in Natty

Changed in shotwell (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Jeremy Nickurak (nickurak) wrote :

Given the simplicity of this fix, can we not easilly get it pulled back for Lucid/Maverick?

Revision history for this message
Omer Akram (om26er) wrote :

if someone could point to a specific commit we could certainly backport it for maverick

Revision history for this message
Adam Dingle (adam-yorba) wrote :

The fix was in this commit

http://trac.yorba.org/changeset/2370

Revision history for this message
Omer Akram (om26er) wrote :

Hey adam would this patch do it for shotwell 0.7.2?

Revision history for this message
Lucas Beeler (lucas-yorba) wrote :

Hi Omer,

I'm an engineer at Yorba on the Shotwell team and the patch looks good to me. I'll ask Jim Nelson (the Shotwell project technical lead) to take a look at it and give you a final thumbs up.

Lucas

Revision history for this message
Jim Nelson (yorba-jim) wrote :

The code looks fine to patch 0.7.2. I've not tested it, but that was the patch that solved this problem.

Revision history for this message
Adam Dingle (adam-yorba) wrote :

OK - our engineers have looked at the patch and it looks OK. I'll emphasize that we haven't built or tested it, however - we do lots of testing on our official releases but if you guys want to cherry pick individual bug fixes then you should do some testing yourselves. I doubt this is a particularly high-risk change, but testing is still always a good idea when pushing to millions of users! :)

Revision history for this message
Omer Akram (om26er) wrote :

i'll prepare a branch with this fix. On the testing part we usually dont push updates right away, we have -proposed repository for those people who wish to help us with testing the bug fixes so when we are certain there there were no regressions with the update they move to the -updates repository and yes I just picked the change from the upstream commit and made it suitable for 0.7.2

also, is there a shotwell 0.7.3 release expected?

Revision history for this message
Omer Akram (om26er) wrote :

Jeremy, could you test the shotwell package from this ppa https://launchpad.net/~om26er/+archive/test/ and see if that solves the issue (I have hard time reproducing the issue).

Revision history for this message
Adam Dingle (adam-yorba) wrote :

Omar: We are not planning an 0.7.3 release at this time. (Our development efforts are currently focused on 0.9, which we plan to release in time for Ubuntu 11.04 this spring.)

Revision history for this message
Adam Dingle (adam-yorba) wrote :

Omer: oops - I spelled your name wrong in my previous comment. Sorry for the typo! :)

Revision history for this message
Ken VanDine (ken-vandine) wrote :

I think this is suitable for an SRU to maverick, and the branch looks good to upload, but we should first provide more details for testers to reproduce.

@m038: can you please comment with the theme you are using to reproduce this bug?

Changed in shotwell (Ubuntu Maverick):
importance: Undecided → Low
status: New → Incomplete
Revision history for this message
m038 (m-gorinskat) wrote :

@Ken VanDine
The repo in ubuntu 10.10 still has 0.7.2

no longer affects: shotwell (Ubuntu Maverick)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.