setup.py for bzr-pqm

Bug #66868 reported by Etienne Goyer
2
Affects Status Importance Assigned to Milestone
Bazaar PQM Plugin
Fix Released
Undecided
Unassigned

Bug Description

Having a setup.py make packaging much easier. The one attached worked for me.

Revision history for this message
Etienne Goyer (etienne-goyer-outlands) wrote :
Revision history for this message
James Henstridge (jamesh) wrote :

I've committed the setup.py script with a few changes:
 * changed the name from 'pqm' to 'bzr-pqm' to match the Launchpad product
 * added a MANIFEST.in file so that sdist includes the license
 * include the URL of the product in the package metadata.

Changed in bzr-pqm:
status: Unconfirmed → Fix Released
Revision history for this message
John A Meinel (jameinel) wrote :

In general we want to use python variable names for plugin names. So really it should be either 'bzr_pqm' or 'pqm'.

I think there is a lot of precidence for using 'bzr-foo' for a plugin named 'foo'. as the launchpad project. And IIRC launchpad doesn't let you use underscores in project names. So we have a fundamental incompatibility between launchpad names and plugins that want to use valid python names.

However, since you only changed the project name to bzr-pqm, but left the installed path as 'pqm', the change seems fine.

Revision history for this message
James Henstridge (jamesh) wrote :

I guess I wasn't quite clear. I left the Python package name as "bzrlib.plugins.pqm".

What I changed was was the name used in the tarball. With Etienne's version, "python setup.py sdist" would generate a tarball called "pqm-$VERSION.tar.gz". I changed it to use "bzr-pqm-$VERSION.tar.gz".

Revision history for this message
Bubba Siggler (bud3) wrote :

I used synaptic Package manager. I type in the search box pqm an got bzr-pqm I tick the box to install is the 0.12-2ubuntu1 is this a good start to work with.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.