Improve invalid branch link title and error message
Bug #667586 reported by
Ian Booth
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Ian Booth | ||
Bug Description
Launchpad now renders invalid branch links as greyed out and displays a message to the user when clicked. However, the message should be improved to reflect the true reason for the broken link eg "Invalid product: foo.".
Related branches
lp:~wallyworld/launchpad/invalid-branch-link-message
- Tim Penhey (community): Approve
-
Diff: 299 lines (+98/-63)5 files modifiedlib/lp/app/browser/linkchecker.py (+8/-3)
lib/lp/app/javascript/lp-links.js (+25/-30)
lib/lp/app/templates/base-layout-macros.pt (+2/-0)
lib/lp/code/errors.py (+26/-9)
lib/lp/code/windmill/tests/test_branch_broken_links.py (+37/-21)
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
| tags: | added: bad-commit-11825 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.11 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-untestable removed: qa-needstesting |
| tags: |
added: qa-needstesting removed: bad-commit-11825 qa-untestable |
| tags: |
added: qa-untestable removed: qa-needstesting |
| tags: | added: bad-commit-11825 |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r11825 <http://