TeamMembership:+index timeout deleting a member
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Edwin Grubbs |
Bug Description
https:/
https:/
Branch: launchpad-rev-11704
Revno: 11704
SQL time: 12684 ms
Non-sql time: 642 ms
Total time: 13326 ms
Statement Count: 274
This is simple death by SQL:
160. 7965 2ms SQL-launchpad-
161. 7968 67ms SQL-launchpad-
162. 8036 1ms SQL-launchpad-
repeats hundreds of times.
I'm arranging for a temporary timeout exception for this to unblock the user.
Changing this to just do a 4 queries should fix it for everything up to to thousands of teams.
Related branches
- Māris Fogels (community): Approve
-
Diff: 681 lines (+261/-191)5 files modifiedlib/lp/registry/browser/tests/test_teammembership.py (+69/-0)
lib/lp/registry/doc/teammembership.txt (+2/-0)
lib/lp/registry/interfaces/teammembership.py (+5/-1)
lib/lp/registry/model/teammembership.py (+78/-160)
lib/lp/registry/tests/test_teammembership.py (+107/-30)
tags: | added: timeout |
Changed in launchpad-registry: | |
status: | New → Triaged |
importance: | Undecided → High |
milestone: | none → series-future |
Changed in launchpad-registry: | |
assignee: | nobody → Brad Crittenden (bac) |
Changed in launchpad: | |
assignee: | Brad Crittenden (bac) → Edwin Grubbs (edwin-grubbs) |
milestone: | none → 11.01 |
status: | Triaged → In Progress |
Changed in launchpad: | |
importance: | High → Critical |
Changed in launchpad: | |
milestone: | 11.01 → 11.02 |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Hi Edwin.
I think you may have fixed this bug will working on member add timeouts. Can you investigate if this is still an issue? If it is fixed, assign it to yourself and mark it fix released.