Ubuntu
indicator-network package

Replace "Wireless: OFF/ON" with "Turn On/Off Wireless"

Bug #664071 reported by Andrea Corbellini
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Network Menu
Fix Released
Medium
Kalle Valo
Network Menu 0.3.6
indicator-network (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

Binary package hint: indicator-network

The indicator for the network and the one for the bluetooth are inconsistent in the way you can turn on/off the devices. The menu item for the network can be:

  Wireless: OFF → clicking this will turn on wireless;
  Wireless: ON → clicking this will turn off wireless.

The menu item for the bluetooth instead is:

  Turn On Bluetooth
  Turn Off Bluetooth

In my opinion, "Turn On/Off <something>" is much more intuitive, so I think that the network menu item should be changed.

Related branches

lp:~kvalo/indicator-network/bug-664071
Conor Curran (community): Approve
Andrew: Pending requested
Diff: 1087 lines (+966/-9)
8 files modified
.bzrignore (+5/-0)
src/backend/network-menu.c (+7/-7)
src/common/dbus-shared-names.h (+2/-0)
src/indicator/Makefile.am (+41/-2)
src/indicator/indicator.c (+27/-0)
src/indicator/tech-menuitem.c (+427/-0)
src/indicator/tech-menuitem.h (+91/-0)
src/indicator/toggleswitch.vala (+366/-0)
lp:ubuntu/natty/indicator-network
Revision history for this message
Kalle Valo (kvalo) wrote :

The plan is to implement a proper widget for this. The current ON/OFF strings in a label are just a hack.

Changed in indicator-network:
status: New → Confirmed
Changed in indicator-network (Ubuntu):
status: New → Confirmed
Changed in indicator-network:
importance: Undecided → Medium
Kalle Valo (kvalo)
Changed in indicator-network:
status: Confirmed → Triaged
Revision history for this message
Kalle Valo (kvalo) wrote :

The on/off button is specified in the spec here:

https://wiki.ubuntu.com/Networking#Network status menu

But if we don't the button widget soon, I think we need to change the label. The current label is very confusing.

311005901 (nitrousinacan-gmail)
summary: - Replace "Wireless: OFF/ON" with "Trun On/Off Wireless"
+ Replace "Wireless: OFF/ON" with "Turn On/Off Wireless"
Kalle Valo (kvalo)
Changed in indicator-network (Ubuntu):
status: Confirmed → Triaged
importance: Undecided → Medium
Kalle Valo (kvalo)
Changed in indicator-network:
status: Triaged → In Progress
assignee: nobody → Kalle Valo (kvalo)
milestone: none → 0.3.6
Kalle Valo (kvalo)
Changed in indicator-network:
status: In Progress → Fix Committed
Revision history for this message
Kalle Valo (kvalo) wrote :

Oops, I marked wrong bug as fix commited.

Changed in indicator-network:
status: Fix Committed → In Progress
Revision history for this message
Kalle Valo (kvalo) wrote :

Network Menu now uses a proper toggle switch which should fix this issue.

Changed in indicator-network:
status: In Progress → Fix Committed
Kalle Valo (kvalo)
Changed in indicator-network:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-network - 0.3.6-0ubuntu1

---------------
indicator-network (0.3.6-0ubuntu1) natty; urgency=low

  * New upstream release
    - New settings app written in vala. Follows the ui design more
      closely. (LP: #732608)
    - New settings app written in vala. Follows the ui design more closely.
    - Flight mode support both in Network Menu and in settings app.
    - Proper toggle switches in Network Menu.
    - Network Menu Wi-Fi on/off button doesn't work (LP: #684574)
    - Replace "Wireless: OFF/ON" with "Turn On/Off Wireless" (LP: #664071)
    - indicator icon showing disconnect even really connected (LP: #705329)
    - port from libnotify-dev to libnotify4-dev (LP: #720753)
  * debian/control
    - changed build depends from libnotify-dev to libnotify4-dev
 -- Ken VanDine <email address hidden> Fri, 11 Mar 2011 02:13:29 -0500

Changed in indicator-network (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.