Referencer

patch to port to new 0.15 API for libpoppler

Bug #661503 reported by Alex L on 2010-10-15

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	Referencer	Fix Released	Undecided	Mads Chr. Olesen	Referencer 1.2.0

Bug Description

The new poppler 0.15 API changes the semantics of the poppler_page_get_text() and poppler_page_get_selected_text() functions. This patch detects the presence of the poppler_page_get_selected_text() function present in poppler >=0.15 and changes the call accordingly. This patch is backwards compatible with compiling against poppler <= 0.14.

Tags:

Related branches

lp:ubuntu/natty/referencer

lp:~referencer-devs/referencer/shiyee_andrease_changes (Merged)

Revision history for this message

Alex L (alexl-users) wrote on 2010-10-15:

Allow compilation with poppler >=0.15 Edit (1.1 KiB, text/x-diff)

Revision history for this message

Alex L (alexl-users) wrote on 2010-10-15:

This has been fixed in Fedora rawhide build:

http://koji.fedoraproject.org/koji/buildinfo?buildID=199328

Revision history for this message

Alex L (alexl-users) wrote on 2010-10-15:

Actually wrong build, this is the latest rawhide build of referencer:

http://koji.fedoraproject.org/koji/buildinfo?buildID=200694

Mads Chr. Olesen (shiyee) on 2011-03-11

Changed in referencer:
status:	New → In Progress

Mads Chr. Olesen (shiyee) on 2011-03-11

Changed in referencer:
assignee:	nobody → Mads Chr. Olesen (shiyee)

Revision history for this message

Enno Gröper (egroeper) wrote on 2012-11-10:

new API fix Edit (713 bytes, text/plain)

I don't think the patch fixes the problem correctly, because "poppler_page_get_text" existed before poppler 0.15.
With the new API it has to be called with other parameters.
I assume, this won't compile, if you try it with an older version of poppler.

In my opinion the correct way to fix this, is checking against poppler version.
See attached patch (extracted from my github fork: https://github.com/egroeper/referencer).

P.S.: Thanks for continuing development!

Revision history for this message

Mads Chr. Olesen (shiyee) wrote on 2012-11-11:

Hi Enno, thanks for your updated patch, I will try it out.
I suppose we could stop supporting the older versions of poppler as these are more than a few years old?
About the other patches in your git repository, do you think these are ready to be merged as well?

Mads Chr. Olesen (shiyee) on 2012-11-18