[trunk] done picking wizard doesn't ask for cost

The cost after merge revision 4288 by Oliver Dony this is the same state, the done process is not recalculating costs and is not asking for cost of in process.

Hello,

It is fixed in trunk-dev-addons_stock branch.
Revno: 3816
Revision ID: <email address hidden>
It will be soon merged with trunk-addons branch

Thanks

I confirm is done!

Sorry I updated the incorrect bug.

This bug is not working in the correct way,

It seams like it was with knowledge, you can check it in comment of commit
<email address hidden>

[Fix] stock: check only product cost method in partial_move wizard

I think you understand bad the concept. _Always_ when a product has average_price the cost should be recalculated, the only diference between done (now process) is that "process " should not ask quantity because you are telling that you are receiving all picking.

BTW i think "Why two wizards, if with partial you can do both tasks?" Somebody can explain the reason?

regards.

Sorry again sbh!

Nhomar, have you checked with the latest trunk after last night's merges.

BTW, the same partial picking wizard is used for all cases.

I think it's fine as we do it now: we always open the partial picking (with cost shown only for average cost products), so this allows maximum flexibility to the user. If user wants to do full picking, then fine, just don't touch the quantities. Otherwise you can also do partial on-the-fly.
This keeps things consistent because the same wizard is used everywhere, also in all list views etc, now.

The difference between "Process Later" and "Process Now" is that "Process Now" will immediately confirm and force-assign the picking, while you would need several steps to have the same result with "Process Later".

For me this bug can be closed, there is certainly no "High" issue anymore since the wizard and cost calculation are correctly triggered now, the rest is just wishlist/cosmetics. Don't you agree?

Hello Oliver.
Yep i used the last revno.
I'm in revno 4336
2 points.
1.- I'm agree in the point of have consistency in all tree views, for this reason have 2 wizards partial and full is right.
2.- For reasons exhaustivaly explained before, i _must_ to recalculate costs every single time, this is the reason of the bug, the costs is not being recalculated with "Process Now".

If we are going to give this option for useability reasons (and i'm not in disagree) we need to put "inteligence" behind this important function, not allow _huge mistakes_ to end users (this is what windows(r) does claiming for useability too, we know the technical effects. ;-)).
In this case i propose, a several things.

A.- Try to recalculate costs, (if quantity to ship < quantity available _only_).
B.- Not recalculate Costs, (if quantity to ship > quantity available _only_).
C.- Record how many Items there were on inventory exactly in the moment i made a "Process Now" or "Process Later" and "partial picking", it can be a calculated field, not shown, i saw in V5 a method that do that.
D.- Record costs on product exactly _in_ this moment. (yep one more time the blessed field), Remember that return should be used for the historical one.!

With this 4 considerations I think is possible make a module called "correcting_stock_costs", that run a wizard with the internal logical to automate this values.

BTW, I think should be better don't have the option for mistakes, but i know it is really difficult sometimes. In tis case to avoid mistakes the correct behavious should be.

What errors can be shown up?
The future cost move_lines generated with invoices of sales will be wrong!, but if we give this recorded values as i am telling you a manual procedure i relativaly easiest, to correct this values.

Conlcusion:
2 option i can see
1.- ask for cost with "Process Now" if (if quantity to ship <= quantity available _only_) and recalculate costs as partial does.
2.- make available this considerations.

Nhomar, perhaps I was not clear in previous comment, sorry. Two points are sufficient to close this bug:

1. The "Process Now" button now opens the Partial Picking wizard in all cases. I just checked again on revision 4345 and it works for all 3 types of pickings.

2. The Partial Picking Wizard is what we want to use for Full Picking, the functionality is the same. If you want to receive full quantities, just don't touch the quantity fields, that's it. There is no reason to make 2 wizards.
And this wizard *does* update the average cost *if* this is an incoming picking, provided there is a product with average cost enabled.

For the rest, let's leave the arguments of other bug reports in their respective bugs, please ;-)

Hello Oliver.

I tried on revno 4345.

-- If I receive by "Incoming Shipping" it is opening the partia picking wizard as you said (when i posted this bug it was not happening), for me OK!.
-- Of I receive by Incomming Product (line by line):
------The partial wizard is opening partial button. OK!.
------The Process button is not working in a correct way, is processing without ask anything ;-). BAD.

IMHO Actually is the unique problem that left to close this bug.

Regards.

other comment in its own bugs ;-)

Updating at revno 4395:

I tried on revno 4395.

-- If I receive by "Incoming Shipping" it is opening the partial picking wizard as you said (when i posted this bug it was not happening), for me OK!.
-- Of I receive by Incomming Product (line by line):
------The partial wizard is opening partial button. OK!.
------The Process button is not working in a correct way, is processing without ask anything ;-). BAD. [It is still there]

"Delivery Products"
-- Partial picking is not showed on form view to send line by line, it is only shown on tree view. BAD
-- Process Now is sending all products, it is good for me, but if i understood well, you say in #8, that we will use only one button for both functions, in this way is. BAD

Hello Nhomar,

For the "stock picking wizard" cost and quantity both are implemented. And for the last comment(#9) of "Delivery product" you can post the new bug. So now i am closing this bug.

Thanks.