Multiple tooltips may be shown when opening building information
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| widelands |
Fix Released
|
Low
|
cghislai | ||
Bug Description
Steps to reproduce:
1. Start a new game. (I've chosen barbarians for this example)
2. Build a building that produce something for other buildings, for instance a tavern. (This is just to be sure to have a hover-text)
3. Move the cursor over the building. The hover-text will display something like "Skipped produce ration because economy does not need ration"
4. Click on the building to open building information.
5. Move the cursor over any of the resources or some of the buttons in the building information.
Actual result:
The correct hover-text for the resources or buttons in the building information dialog will be shown, in addition the hover-text for the building is shown behind the dialog. This leads to two separate hover-texts being shown, one partially hidden.
Expected result:
I expect only one hover-text to be shown, the one in the current dialog.
It seems to me, the building does not register when the dialog is opened and continue to show the hover-text. Perhaps opening the dialog should trigger the same event as when moving the cursor away (mouse_out?).
Widelands bzr rev 5563 on Ubuntu 10.04.
Related branches
- SirVer: Approve
-
Diff: 1269 lines (+309/-216)36 files modifiedsrc/chat.h (+6/-0)
src/constants.h (+1/-1)
src/debugconsole.cc (+4/-0)
src/gamecontroller.cc (+31/-3)
src/logic/building.cc (+6/-0)
src/logic/building.h (+5/-0)
src/logic/production_program.cc (+2/-2)
src/logic/productionsite.cc (+1/-1)
src/logic/trainingsite.cc (+1/-6)
src/network/internet_gaming.cc (+8/-1)
src/network/internet_gaming.h (+3/-0)
src/network/netclient.cc (+9/-0)
src/network/netclient.h (+1/-0)
src/network/nethost.cc (+7/-0)
src/save_handler.cc (+10/-2)
src/timestring.cc (+15/-0)
src/timestring.h (+5/-0)
src/ui_basic/progressbar.cc (+9/-12)
src/ui_basic/table.cc (+11/-22)
src/ui_fsmenu/loadgame.cc (+3/-8)
src/ui_fsmenu/loadreplay.cc (+3/-8)
src/ui_fsmenu/mapselect.cc (+3/-3)
src/wlapplication.cc (+7/-5)
src/wui/building_ui.cc (+8/-1)
src/wui/buildingwindow.cc (+5/-46)
src/wui/buildingwindow.h (+0/-1)
src/wui/fieldaction.cc (+1/-43)
src/wui/game_main_menu_save_game.cc (+20/-13)
src/wui/game_main_menu_save_game.h (+1/-1)
src/wui/game_message_menu.cc (+5/-13)
src/wui/interactive_base.cc (+64/-0)
src/wui/interactive_base.h (+3/-0)
src/wui/interactive_player.cc (+13/-10)
src/wui/interactive_player.h (+3/-0)
src/wui/productionsitewindow.cc (+34/-13)
src/wui/productionsitewindow.h (+1/-1)
- SirVer: Approve
- cghislai (community): Abstain
-
Diff: 611 lines (+143/-34)20 files modifiedsrc/editor/ui_menus/editor_main_menu_load_map.cc (+4/-1)
src/editor/ui_menus/editor_main_menu_save_map.cc (+10/-3)
src/editor/ui_menus/editor_player_menu.cc (+2/-1)
src/graphic/font_handler.cc (+7/-3)
src/graphic/render/gl_surface_texture.cc (+32/-3)
src/graphic/rendertarget.cc (+9/-0)
src/io/dedicated_log.cc (+2/-1)
src/logic/bob.cc (+1/-1)
src/network/internet_gaming.cc (+7/-1)
src/ui_basic/panel.cc (+32/-10)
src/ui_basic/panel.h (+3/-1)
src/ui_basic/table.cc (+7/-2)
src/ui_basic/window.cc (+9/-0)
src/ui_basic/window.h (+1/-0)
src/ui_fsmenu/editor_mapselect.cc (+4/-1)
src/ui_fsmenu/launchMPG.cc (+3/-1)
src/ui_fsmenu/mapselect.cc (+4/-1)
src/wui/building_ui.cc (+0/-2)
src/wui/mapview.cc (+0/-1)
src/wui/multiplayersetupgroup.cc (+6/-1)
| Hans Joachim Desserud (hjd) wrote | #1 |
| Changed in widelands: | |
| status: | New → Confirmed |
| importance: | Undecided → Low |
| summary: |
- Multiple hover-texts may be shown when opening building information + Multiple tooltips may be shown when opening building information |
| tags: | added: ui |
| Changed in widelands: | |
| milestone: | none → build18-rc1 |
| Changed in widelands: | |
| assignee: | nobody → cghislai (charlyghislain) |
| status: | Confirmed → In Progress |
| Hans Joachim Desserud (hjd) wrote | #2 |
| cghislai (charlyghislain) wrote | #3 |
| Changed in widelands: | |
| status: | In Progress → Fix Committed |
| SirVer (sirver) wrote | #4 |
| Changed in widelands: | |
| status: | Fix Committed → Fix Released |
I'm still able to reproduce this issue, even after the attached branch was merged in r6629. See the attached screenshot. Might be slightly trickier, but if you move the open window to overlap the building, you should be able to trigger it.
PS. The missing parts of the screenshot are reported as bug 1202146.
In general, you seem to have done a great job fixing bugs lately. That said, I think it would be better to submit separate branches/merge requests for each bug rather than gathering lots of fixes in one giant merge. First of all, it makes it easier to get an overview as all changes are related to a single issue. If there are any problems with the suggested patch, we can get those sorted out while merging the fixes for other bugs so that they don't get delayed in the mean time. It also makes it clearer to see what was fixed in a particular commit, for instance I don't know if all bugs linked to the branch recently merged can be set to Fix Committed or if only some of them can. If a bug is introduced by a particular commit, it is easy to look up what really changed in the future if the set of changes is smaller.
If bugs are closely related it would of course make sense to fix them at the same time, but if they are affecting unrelated parts of the code it is usually better to file separate merge requests (or alternatively wait until the first fix is in).
Keep up the good work. :)