log: Recent log list race

Bug #655645 reported by Stefano Rivera
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ibid
Fix Released
Medium
Stefano Rivera

Bug Description

This looks racy:

Event: {'account': None, 'responses': [], 'source': u'atrum', 'state': u'offline', 'session': <sqlalchemy.orm.session.Session object at 0x4fa9090>, 'processed': False, 'time': datetime.datetime(2010, 10, 6, 11, 1, 27, 667092), 'identity': 14, 'message': u'Ping timeout', 'type': u'state', 'public': True, 'channel': None, 'sender': {'nick': u'Hodgestar', 'connection': u'Hodgestar', 'id': u'Hodgestar'}}
Traceback (most recent call last):
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/core.py", line 29, in process
    processor.process(event)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/__init__.py", line 137, in process
    method(event)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/log.py", line 176, in log_handler
    self.log_event(event)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/log.py", line 169, in log_event
    file = self.get_logfile(event)
  File "/home/stefanor/bzr/ibid/stefanor/tibid/ibid/plugins/log.py", line 124, in get_logfile
    self.recent_logs.remove(log)
ValueError: list.remove(x): x not in list

Tags: log regression

Related branches

Changed in ibid:
assignee: nobody → Stefano Rivera (stefanor)
status: New → In Progress
Changed in ibid:
status: In Progress → Fix Committed
Changed in ibid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.