Ubuntu
ampache package

ampache package in maverick missing xspf flash files

Bug #654993 reported by Everett Guerny on 2010-10-05

This bug affects 2 people

Affects		Status	Importance	Assigned to	Milestone
	ampache (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

Binary package hint: ampache

I recently upgraded my server from Lucid to Maverick and found that in-browser Flash-based playback using ampache no longer worked. When one tries to start such playback, nothing appears in the browser window that is supposed to house the Flash-based player.

I dug through the php files and found reference to a couple of files that were missing:

/usr/share/ampache/www/modules/flash/xspf_jukebox.swf
/usr/share/ampache/www/modules/flash/xspf_jukebox.fla

I grabbed these two files from the "stable" tar.gz on ampache.org, dropped them into the directory and playback then began working as expected. Please make sure these essential files are added to the Ubuntu package.

Related branches

lp:ubuntu/natty/ampache

Revision history for this message

Charlie_Smotherman (cjsmo) wrote on 2010-10-10:

Everrett

Thank you for the bug report.

I refer you to debian bug #591202 and this thread on debian-devel mailing list

http://lists.debian.org/debian-devel/2010/08/msg00082.html

Until free tools become available to compile xspf_jukebox.fla at package build time, these files will not be included in the package sorry. :(

Changed in ampache (Ubuntu):
status:	New → Invalid

Revision history for this message

Everett Guerny (everett) wrote on 2010-10-11:

Charlie, thank you for your response and I certainly appreciate the licensing situation here.

Question, though: do you think it would be possible to have the Flash option removed from the Ubuntu/Debian version of the package, or somehow make the situation clear to those who try to use the feature, rather than silently failing as it does now? It took me some work to track down the source of the issue, which confused me all the more because this issue only began when I upgraded my server from Lucid to Maverick; if I'm not mistaken, the Flash player functionality has been working in all previous versions from the Ubuntu repositories.

Thanks again for clarifying this for me!

Revision history for this message

Charlie_Smotherman (cjsmo) wrote on 2010-10-11:

Everett,

These change took place while squeeze and maverick have been frozen, so the changes made had to be minimal in nature for the debian/ubuntu release teams to accept them.

If you have a look in /usr/share/doc/ampache/README.Debian.gz the very first thing you see is an explanation as to why the xspf_jukebox.swf was removed and how to work around it. This is the best I could due under the circumstances.

I am packaging the xspf_jukebox and will try to get it into multiverse/contrib so users can get it with apt-get.

I'm also going to get with upstream to see if there is some way to have a notification pop up explaining the situation when the user attempts to use the flash player.

Patches welcome :)

Best regards
Charlie

Revision history for this message

Stefan Mächler (stefan-maechler) wrote on 2010-10-21:

notification.patch Edit (1.6 KiB, text/plain)

Charlie,

It took me some time to find out why the Flash player functionality was not working anymore. However, it would be nice if there was some kind of notification why it is not working anymore.

Here is a small patch which could help.

Regards
Stefan

Revision history for this message

Charlie_Smotherman (cjsmo) wrote on 2010-10-27:

Stefan,

Thank you for the patch, give me some time to test the patch and I will include it into 3.5.4-8ubuntu4. I have recently added a small script (grab_xspf.sh) that grabs the xspf player and puts it back into place.

http://bazaar.launchpad.net/~cjsmo/%2Bjunk/ampache/annotate/head:/tags/3.5.4-8ubuntu2/debian/grab_xspf.sh