Ubuntu
likewise-open package

likewise-open fails to build from source in maverick

Bug #651138 reported by Matthias Klose
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
likewise-open (Ubuntu)
Fix Released
High
Thierry Carrez
Ubuntu ubuntu-10.10
Maverick
Fix Released
High
Thierry Carrez
Ubuntu ubuntu-10.10

Bug Description

Binary package hint: likewise-open

Running build stage
make[1]: Entering directory `/build/user-likewise-open_5.4.0.42111-2ubuntu1.2-i386-KlNi8J/likewise-open-5.4.0.42111/lsass'
CDPATH="${ZSH_VERSION+.}:" && cd . && /bin/bash /build/user-likewise-open_5.4.0.42111-2ubuntu1.2-i386-KlNi8J/likewise-open-5.4.0.42111/lsass/missing --run aclocal-1.11 -I m4
configure.in:917: error: AC_CHECK_MEMBER: requires literal arguments
../../lib/autoconf/types.m4:880: AC_CHECK_MEMBER is expanded from...
../../lib/autoconf/types.m4:913: AC_CHECK_MEMBERS is expanded from...
configure.in:917: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal-1.11: autom4te failed with exit status: 1
make[1]: *** [aclocal.m4] Error 1
make[1]: Leaving directory `/build/user-likewise-open_5.4.0.42111-2ubuntu1.2-i386-KlNi8J/likewise-open-5.4.0.42111/lsass'
Exiting on error 2

Elapsed Time (lsass): 49 seconds

Exiting on error 2
Exiting on error 2
make: *** [build-stamp] Error 1

Tags: server-mrs
Matthias Klose (doko)
Changed in likewise-open (Ubuntu):
importance: Undecided → High
milestone: none → ubuntu-10.10
status: New → Confirmed
Dave Walker (davewalker)
tags: added: server-mrs
Revision history for this message
Thierry Carrez (ttx) wrote :

The following stanza in lsass/configure.in fails:

AC_CHECK_MEMBERS([ucontext_t.uc_mcontext,
  ucontext_t.uc_mcontext->__ss.__rip,
  ucontext_t.uc_mcontext->__ss.__eip],
[], [], [AC_INCLUDES_DEFAULT
#ifdef HAVE_EXECINFO_H
# include <execinfo.h>
#endif
])

It was added to define HAVE_UCONTEXT_T_UC_MCONTEXT____SS___RIP (and ___EIP) which are apparently only defined in Mac 32/64bit (the code guarded by that ifdef enables Mac 32/64bit instruction pointer in lsass/server/lsassd/backtrace.c):

 #elif defined(REG_RIP)
         // Linux 64bit instruction pointer
         ppFunctions[1] = (void *)pContext->uc_mcontext.gregs[REG_RIP];
+#elif defined(HAVE_UCONTEXT_T_UC_MCONTEXT____SS___RIP)
+ // Mac 64bit instruction pointer
+ ppFunctions[1] = (void *)pContext->uc_mcontext->__ss.__rip;
+#elif defined(HAVE_UCONTEXT_T_UC_MCONTEXT____SS___EIP)
+ // Mac 32bit instruction pointer
+ ppFunctions[1] = (void *)pContext->uc_mcontext->__ss.__eip;
 #else
         // Linux 32bit instruction pointer
         ppFunctions[1] = (void *)pContext->uc_mcontext.gregs[REG_EIP];

It sounds rather safe to patch it out, I'll propose an upload to that effect.

Changed in likewise-open (Ubuntu Maverick):
assignee: nobody → Thierry Carrez (ttx)
status: Confirmed → In Progress
Thierry Carrez (ttx)
Changed in likewise-open (Ubuntu Maverick):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package likewise-open - 5.4.0.42111-2ubuntu2

---------------
likewise-open (5.4.0.42111-2ubuntu2) maverick; urgency=low

  * debian/patches/disable-mac-IP-to-fix-ftbfs.diff:
    Disable the code that enabled Mac 32bit/64bit instruction pointers in
    lsassd backtraces, to fix FTBFS in configure.in stanza (LP: #651138)
 -- Thierry Carrez (ttx) <email address hidden> Mon, 04 Oct 2010 11:27:30 +0200

Changed in likewise-open (Ubuntu Maverick):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.