gio-sharp leaks every FileAdapter

Bug #650536 reported by David Nielsen
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gio-sharp (Ubuntu)
Fix Committed
Undecided
Unassigned

Bug Description

ricotz discovered a nasty memory leak in gio-sharp. This is fixed in gio-sharp git.

The fix:
http://github.com/mono/gio-sharp/commit/d264425e9a89ffcde80c9561eb6290ceafa44083

Cleanups and enhancements to the fix.
http://github.com/mono/gio-sharp/commit/73442d0ea8d4ef7026c40303dad9048d9f894807
http://github.com/mono/gio-sharp/commit/86bde46eff37d855766dbc4360dd11e28cebbf3a

Master contains only one additional fix to remove .mdb files from the .pc files which we might also want to ship.

http://github.com/mono/gio-sharp/commits/master

Revision history for this message
David Nielsen (davidnielsen-deactivatedaccount) wrote :

There is some unclarity if the fix introduces undesired bad stuff(tm), on advice from Gabriel Burt, please wait shipping this pending feedback from Rico.

Revision history for this message
David Nielsen (davidnielsen-deactivatedaccount) wrote :

Feedback provided via #banshee:

<ricotz> gabaug, hi, i saw the conversation and the patch might work, it seems the whole ginterface handling needs some rework in the generator. but currently i have no time to look into it further :(
<gabaug> ricotz: ok...why had you suggested reverting the patch? you no longer think that needs to be done?
<ricotz> gabaug, introducing this will break docky on the next build
<gabaug> ricotz: how so?
<ricotz> we are using it quite heavily which causes some threading problems or something
 this will need a large code rework of docky to fix this
 it would be great if someone could have a look at it to confirm this fix is doing the right thing, while it isnt the best way so this is more a structural problem with all Interface/Adapter bindings in gio

Revision history for this message
David Nielsen (davidnielsen-deactivatedaccount) wrote :

While these supposedly does fix leaks, they break Banshee (and as stated above, Docky)

https://bugzilla.gnome.org/show_bug.cgi?id=635501

Revision history for this message
Iain Lane (laney) wrote :

This will be fixed when #754882 is actioned and we get 2.22.3

Changed in gio-sharp (Ubuntu):
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.