DBus delete_share doesn't work for shares made by the user to others
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Client |
Fix Released
|
Critical
|
Guillermo Gonzalez | ||
| Stable-1-4 |
Fix Released
|
Critical
|
Guillermo Gonzalez | ||
| ubuntuone-client (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Bug Description
(04:25:19 PM) verterok: Chipaca, nessita: so we need to add support for this in AQ and change the call in DBus to call aq.delete_share
(04:25:46 PM) nessita: Chipaca, verterok: seems like it. Right now, dbus.delete_share calls vm.delete_volume that calls aq.delete_volume
For example, when nautilus plugin tries to delete a share made by the user to others, what happens is:
method call sender=:1.742 -> dest=com.
string "086867e4-
signal sender=:1.650 -> dest=(null destination) serial=100 path=/shares; interface=
array [
dict entry(
string "volume_id"
string "086867e4-
)
]
string "DOES_NOT_EXIST"
Related branches
- Rodrigo Moya (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 520 lines (+299/-24)8 files modifiedcontrib/testing/testcase.py (+2/-0)
tests/syncdaemon/test_action_queue.py (+50/-1)
tests/syncdaemon/test_dbus.py (+69/-0)
tests/syncdaemon/test_vm.py (+98/-11)
ubuntuone/syncdaemon/action_queue.py (+30/-0)
ubuntuone/syncdaemon/dbus_interface.py (+21/-12)
ubuntuone/syncdaemon/event_queue.py (+4/-0)
ubuntuone/syncdaemon/volume_manager.py (+25/-0)
- Facundo Batista (community): Approve
- Natalia Bidart (community): Approve
-
Diff: 519 lines (+299/-23)8 files modifiedcontrib/testing/testcase.py (+2/-0)
tests/syncdaemon/test_action_queue.py (+50/-1)
tests/syncdaemon/test_dbus.py (+69/-0)
tests/syncdaemon/test_vm.py (+98/-11)
ubuntuone/syncdaemon/action_queue.py (+30/-0)
ubuntuone/syncdaemon/dbus_interface.py (+21/-11)
ubuntuone/syncdaemon/event_queue.py (+4/-0)
ubuntuone/syncdaemon/volume_manager.py (+25/-0)
- dobey (community): Needs Resubmitting
-
Diff: 967 lines (+710/-23) (has conflicts)9 files modifiedcontrib/testing/testcase.py (+2/-0)
nautilus/ubuntuone-nautilus.c (+410/-0)
tests/syncdaemon/test_action_queue.py (+50/-1)
tests/syncdaemon/test_dbus.py (+69/-0)
tests/syncdaemon/test_vm.py (+99/-11)
ubuntuone/syncdaemon/action_queue.py (+30/-0)
ubuntuone/syncdaemon/dbus_interface.py (+21/-11)
ubuntuone/syncdaemon/event_queue.py (+4/-0)
ubuntuone/syncdaemon/volume_manager.py (+25/-0)
| Natalia Bidart (nataliabidart) wrote | #1 |
| Changed in ubuntuone-client: | |
| importance: | Undecided → Critical |
| status: | New → Triaged |
| assignee: | nobody → Ubuntu One Foundations+ team (ubuntuone-foundations+) |
| tags: | added: foundations+ u1-maverick |
| Guillermo Gonzalez (verterok) wrote | #2 |
| Changed in ubuntuone-client: | |
| assignee: | Ubuntu One Foundations+ team (ubuntuone-foundations+) → Guillermo Gonzalez (verterok) |
| status: | Triaged → In Progress |
| Changed in ubuntuone-client (Ubuntu): | |
| status: | New → Confirmed |
| importance: | Undecided → Critical |
| assignee: | nobody → Ubuntu One Ops+ team (ubuntuone-ops+) |
| importance: | Critical → High |
| Changed in ubuntuone-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-client (Ubuntu): | |
| status: | Confirmed → Fix Committed |
| Changed in ubuntuone-client: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntuone-client (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntuone-client (Ubuntu): | |
| assignee: | Registry Administrators (registry) → nobody |
(04:51:33 PM) verterok: nessita: we could add this without changing API
(04:51:41 PM) nessita: verterok: we could?
(04:52:05 PM) verterok: nessita: using the same signals, without changing anything dbus-wise
(04:52:14 PM) verterok: nessita: only, what's called in delete_share exposed method
(04:52:41 PM) verterok: nessita: but we need 2 new events, AQ_DELETE_