IDistroSeries.deriveDistroSeries() should use the security adapter
Bug #643369 reported by
Steve Kowalik
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Julian Edwards | ||
Bug Description
IDistroSeries.
Related branches
lp:~julian-edwards/launchpad/derive-permissions-bug-643369
- Graham Binns (community): Approve (code)
-
Diff: 190 lines (+40/-40)4 files modifiedlib/lp/registry/interfaces/distroseries.py (+25/-20)
lib/lp/registry/model/distroseries.py (+0/-5)
lib/lp/registry/stories/webservice/xx-derivedistroseries.txt (+4/-2)
lib/lp/registry/tests/test_derivedistroseries.py (+11/-13)
| Changed in launchpad-registry: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| Changed in launchpad-registry: | |
| milestone: | none → series-future |
| tags: | added: derived-distributions |
| tags: |
added: derivation removed: derived-distributions |
Revision history for this message
| Julian Edwards (julian-edwards) wrote | #1 |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #2 |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Julian Edwards (julian-edwards) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
It should be checking to see if the context distro is an IDerivedDistro and checking to see if the user is one of its drivers. For a non IDerivedDistro it should stay as admin for now because of the Ubuntu problem with an inflated drivers team.