Poor error messages from the smart server
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Tim Penhey | ||
Bug Description
perseus:
bzr: ERROR: Server sent an unexpected error: ('error', '<Fault -1: "Unexpected Zope exception: CannotHaveLinke
<wgrant> It's at least only broken for branches that don't exist.
So it's just the error message that sucks.
<deryck> right. So it's a bad error.
right
the branch just doesn't exist.
<wgrant> And the new code to automatically create them goes a bit wrong in the source package case.
[...]
<rockstar> mdz, launchpad-code would be good. I'm sure we can re-target if it's not our problem.
<deryck> rockstar, is there a bug for the error? And should he do something to get the branch created?
<rockstar> deryck, unfortunately, I don't know much about source package branches, so I'll have to dig in the code a bit.
<rockstar> mdz, yes, please file a bug.
Related branches
- Jeroen T. Vermeulen (community): Approve (code)
- Robert Collins (community): Approve (release-critical)
- Launchpad code reviewers: Pending (release-critical) requested
-
Diff: 86 lines (+29/-8)2 files modifiedlib/lp/code/xmlrpc/codehosting.py (+11/-2)
lib/lp/code/xmlrpc/tests/test_codehosting.py (+18/-6)
| Tim Penhey (thumper) wrote | #1 |
| Changed in launchpad-code: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| summary: |
- CannotHaveLinkedBranch: <Distribution \'Ubuntu\' (ubuntu)> cannot have - linked branches."> + Poor error messages from the smart server |
| tags: | added: codehosting-ssh |
| Changed in launchpad-code: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Tim Penhey (thumper) |
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| Changed in launchpad-code: | |
| milestone: | none → 10.10 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
The main problem here is a bad error message.
The underlying problem is that there are no official source package branches for apport. Since there are no official links, the short lp:ubuntu/apport name does not work.
The change in the last release effectively pushed the checking into a different layer, and that layer is not checking things nicely as it had expected a previous layer to do that, and now it isn't.