warn when cached TALes in loop does not provide extra key info
Bug #627033 reported by
Edwin Grubbs
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Robert Collins | ||
Bug Description
I recently encountered a template where it was caching in a loop but without providing the third argument to the "cache" TALes so that the memcache key will be unique for each object. The "cache" TALes could easily raise an exception if the same position in a source file is cached without specifying extra key info. If it is still desirable that non-changeable lists be cached distinctly using the counter, it could be stated explicitly in the third argument.
Related branches
lp:~lifeless/launchpad/memcache
- Curtis Hovey (community): Approve (code)
- Steve Kowalik (community): Approve (code*)
-
Diff: 119 lines (+53/-7)3 files modifiedlib/lp/services/memcache/client.py (+16/-1)
lib/lp/services/memcache/doc/tales-cache.txt (+33/-0)
lib/lp/services/memcache/tales.py (+4/-6)
| Changed in launchpad-foundations: | |
| status: | New → Triaged |
| status: | Triaged → New |
| status: | New → Triaged |
| importance: | Undecided → Wishlist |
| tags: | added: trivial |
| Changed in launchpad: | |
| importance: | Wishlist → Low |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Robert Collins (lifeless) |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r15393 <http://