Launchpad itself

Canceling a "request pending" recipe not possible

Bug #624630 reported by Remi Debay
22
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

Hi,

There are no options to cancel a request for build a recipe.

There might have a button to cancel the request to avoid useless builds.

Cheers,

Rémi

Related branches

lp:~wgrant/launchpad/recipe-cancel
Colin Watson (community): Approve
Diff: 438 lines (+122/-77)
8 files modified
lib/lp/code/browser/configure.zcml (+1/-1)
lib/lp/code/browser/sourcepackagerecipebuild.py (+8/-19)
lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py (+18/-30)
lib/lp/code/configure.zcml (+6/-1)
lib/lp/code/interfaces/sourcepackagerecipebuild.py (+44/-9)
lib/lp/code/model/sourcepackagerecipebuild.py (+25/-5)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+2/-1)
lib/lp/code/model/tests/test_sourcepackagerecipebuild.py (+18/-11)
Revision history for this message
Aaron Bentley (abentley) wrote : Re: [Bug 624630] [NEW] Canceling a "request pending" recipe not possible

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status triaged
 importance medium
 tags recipe

On 08/26/2010 09:03 AM, Remi Debay wrote:
> There are no options to cancel a request for build a recipe.
>
> There might have a button to cancel the request to avoid useless builds.

We would like that, but our architecture doesn't yet provide a clean way
of cancelling builds.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkx2bVEACgkQ0F+nu1YWqI0NYwCfaZ3qwSrcWDQhFUQOKh+Nzhkw
Zl0AmwRXTTTp8WAP543p9barPZ9pMFJY
=eaP6
-----END PGP SIGNATURE-----

Changed in launchpad-code:
importance: Undecided → Medium
status: New → Triaged
Aaron Bentley (abentley)
tags: added: recipe
Revision history for this message
Aaron Bentley (abentley) wrote :

It doesn't seem hard to cancel a build that is not yet running, but there are race conditions that mean we might attempt to cancel a build that is already running, and this would end badly.

Revision history for this message
janisozaur (janisozaur) wrote :

A way to cancel a build that is already running would also be useful.

Revision history for this message
Tamer Saadeh (tamersaadeh) wrote :

I think that this bug's 'Importance' should be increase to at least 'High' because when a failure in the build bots occur, I think many people (including myself) will probably want to cancel their request. This will hopefully cause the number of requests to decrease, which helps in the recovery phase after the bots are back online. When they cancel them, they would then be able to build it manually and fix and update it, without wasting as the bots' resources.

Curtis Hovey (sinzui)
Changed in launchpad:
importance: Medium → Low
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r17733 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/17733>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
tags: added: qa-ok
removed: qa-needstesting
Colin Watson (cjwatson)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.