Ubuntu One Client

Get info through u1sdtool doesn't work for shared paths

Bug #621924 reported by Facundo Batista
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Fix Released
High
Guillermo Gonzalez
ubuntuone-client (Ubuntu)
Fix Released
High
Unassigned
Nominated for Maverick by Guillermo Gonzalez

Bug Description

$ ls -l /home/facundo/Ubuntu\ One/Shared\ With\ Me/magicicada-lt\ from\ Naty\ Bidart/logo.png
-r--r--r-- 1 facundo facundo 101563 2010-07-04 16:01 /home/facundo/Ubuntu One/Shared With Me/magicicada-lt from Naty Bidart/logo.png

$ u1sdtool --info=/home/facundo/Ubuntu\ One/Shared\ With\ Me/magicicada-lt\ from\ Naty\ Bidart/logo.png

Oops, an error ocurred:
Traceback (most recent call last):
Failure: dbus.exceptions.DBusException: org.freedesktop.DBus.Python.KeyError: Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/dbus/service.py", line 702, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/home/facundo/canonical/u1-client/aq-memory-improvements/ubuntuone/syncdaemon/dbus_interface.py", line 966, in get_metadata
    mdobj = self.fs_manager.get_by_path(path.encode('utf-8'))
  File "/home/facundo/canonical/u1-client/aq-memory-improvements/ubuntuone/syncdaemon/filesystem_manager.py", line 587, in get_by_path
    mdid = self._idx_path[path]
KeyError: '/home/facundo/Ubuntu One/Shared With Me/magicicada-lt from Naty Bidart/logo.png'

This is directly related to "Shared with me" being a synmlink.

Most probably the bug is in the DBus interface, not in u1sdtool.

Related branches

lp:~verterok/ubuntuone-client/fix-621924
John Lenton (community): Approve
Facundo Batista (community): Approve
Diff: 107 lines (+70/-2)
2 files modified
tests/syncdaemon/test_dbus.py (+66/-0)
ubuntuone/syncdaemon/dbus_interface.py (+4/-2)
lp:ubuntu/maverick/ubuntuone-client
Revision history for this message
Guillermo Gonzalez (verterok) wrote :

Hi,

This is a bug introduced recently, check revision 643 for the change. As u1sdtool is now using abspath, it's breaking.

Cheers,

Guillermo Gonzalez (verterok)
Changed in ubuntuone-client:
assignee: nobody → Guillermo Gonzalez (verterok)
status: Confirmed → In Progress
Changed in ubuntuone-client (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Ubuntu One Ops+ team (ubuntuone-ops+)
assignee: Ubuntu One Ops+ team (ubuntuone-ops+) → nobody
milestone: none → ubuntu-10.10
assignee: nobody → Ubuntu One Ops+ team (ubuntuone-ops+)
milestone: ubuntu-10.10 → none
dobey (dobey)
Changed in ubuntuone-client:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 1.4.0-0ubuntu1

---------------
ubuntuone-client (1.4.0-0ubuntu1) maverick; urgency=low

  * New upstream release:
    - Fix crash when disabling UDFs (Rodrigo Moya) (LP: #625525)
    - Only show one question dialog when disabling UDFs (Rodrigo Moya)
      (LP: #624212)
    - Cancelled uploads don't survive forever now (Facundo Batista)
    - Remove ancient ubuntuone/oauthdesktop reference from Makefile.am
      (Rodney Dawes)
    - Fix dbus interface get_metadata methods to use the realpath
      (Guillermo Gonzalez) (LP: #621924)
    - Make dbus interface handle WaitForCondition in waiting_content properly
      (and any other 'empty' commands) (Guillermo Gonzalez)
    - Some code cleanup when analysing code for a bug that was already fixed
      (Facundo Batista)
    - Some code cleanups in AQ (Facundo Batista)
    - Draw a separator between recently used contacts and the rest
      (Rodrigo Moya) (LP: #614047)
    - Use correct app name when clearing tokens in ubuntuone-preferences
      (Rodrigo Moya) (LP: #628852)
    - When user cancels deletion of UDF, keep the toggle button's status
      (Rodrigo Moya)
    - When the contact has no name, use whatever is available (Rodrigo Moya)
      (LP: #614055)
    - Remove old oauthdesktop references (Natalia Bidart) (LP: #632502)
    - Fix u1sdtool --rescan_from_scratch args parsing to support VOLUME_ID=""
      (Guillermo Gonzalez) (LP: #619958)
  * debian/python-ubuntuone-client.install:
    - Remove oauthdesktop files from installation
 -- Rodrigo Moya <email address hidden> Wed, 08 Sep 2010 13:26:04 +0200

Changed in ubuntuone-client (Ubuntu):
status: Confirmed → Fix Released
Rodrigo Moya (rodrigo-moya)
Changed in ubuntuone-client:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in ubuntuone-client (Ubuntu):
assignee: Registry Administrators (registry) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.