Please include sasl support into KVM

Hi Christian, thanks for the bug report!

I think this looks like a reasonable request, but I have question...

Is this a new build-time dependency, or just a run time dependency?

ie, if you just 'sudo apt-get install qemu-kvm cyrus-sasl', and then run with vnc/sasl, does it work?

If so, we can simply add a recommends on cyrus-sasl.

Or, does qemu-kvm need to be rebuilt with some additional sasl library? If so, what is the exact library we need to compile against?

Thanks!
:-Dustin

You need to recompile kvm. I tried it with simply the libsasl2-dev package.

debian/rules:

--- rules 2010-08-21 23:58:53.000000000 +0200
+++ rules.new 2010-08-22 00:02:54.681408215 +0200
@@ -11,6 +11,7 @@
 # Note: We differ from Debian here by favoring the pulseaudio driver, since that's default in Ubuntu.
 # Users override this when calling qemu by exporting the environment variable QEMU_AUDIO_DRV.
 conf_arch += --audio-drv-list="pa,alsa,sdl,oss"
+conf_arch += --enable-vnc-sasl
 endif
 ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
 conf_arch += --audio-drv-list=oss,sdl,pa

Add libsasl2-dev to the debian/control file.

Rebuild

...
dh_testdir
./configure \
     --target-list="" \
     --prefix=/usr \
     --interp-prefix=/etc/qemu-binfmt/%M \
     --disable-blobs \
     --disable-strip \
     --audio-drv-list="pa,alsa,sdl,oss" --enable-vnc-sasl
Install prefix /usr
BIOS directory /usr/share/qemu
binary directory /usr/bin
Manual directory /usr/share/man
ELF interp prefix /etc/qemu-binfmt/%M
Source path /usr/local/src/qemu-kvm-0.12.3+noroms
C compiler gcc
Host C compiler gcc
CFLAGS -O2 -g -g -O2 -Wall -g -O2
QEMU_CFLAGS -m64 -Wold-style-definition -Wold-style-declaration -I. -I$(SRC_PATH) -U_FORTIFY_SOURCE -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing
LDFLAGS -Wl,--warn-common -m64 -g -Wl,-Bsymbolic-functions
make make
install install
host CPU x86_64
host big endian no
target list i386-softmmu x86_64-softmmu arm-softmmu cris-softmmu m68k-softmmu microblaze-softmmu mips-softmmu mipsel-softmmu mips64-softmmu mips64el-softmmu ppc-softmmu ppcemb-softmmu ppc64-softmmu sh4-softmmu sh4eb-softmmu sparc-softmmu sparc64-softmmu i386-linux-user x86_64-linux-user alpha-linux-user arm-linux-user armeb-linux-user cris-linux-user m68k-linux-user microblaze-linux-user mips-linux-user mipsel-linux-user ppc-linux-user ppc64-linux-user ppc64abi32-linux-user sh4-linux-user sh4eb-linux-user sparc-linux-user sparc64-linux-user sparc32plus-linux-user
tcg debug enabled no
gprof enabled no
sparse enabled no
strip binaries no
profiler no
static build no
-Werror enabled no
SDL support yes
curses support yes
curl support yes
check support no
mingw32 support no
Audio drivers pa alsa sdl oss
Extra audio cards ac97 es1370 sb16
Block whitelist
Mixer emulation no
VNC TLS support yes <---
VNC SASL support yes <---
...

This also enables ACLs. Missing sasl is a security hole for vnc in my opinion.

As you can see, sasl will be easily included. I see it as a bug for current Lucid, so it _could_/should go as an update into Lucid, but I fear it is a feature for upcoming release ;-)

Regards
Christian

Perfect, thanks.

I can't build locally right now, so I've sent a test build to my ppa. Will check back in a few hours. If you're interested in testing my new package, see:
 * https://launchpad.net/~kirkland/+archive/ppa

Look for:
 * qemu-kvm_0.12.5+noroms-0ubuntu3~ppa1

This bug was fixed in the package qemu-kvm - 0.12.5+noroms-0ubuntu3

---------------
qemu-kvm (0.12.5+noroms-0ubuntu3) maverick; urgency=low

  * debian/rules, debian/control: enable vnc sasl in the build, LP: #621639
 -- Dustin Kirkland <email address hidden> Tue, 24 Aug 2010 09:56:34 -0400