replace use of stringstream with boost::lexical_cast
Bug #621331 reported by
Monty Taylor
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Drizzle |
Fix Released
|
High
|
Billy Earney | ||
7.0 |
Fix Released
|
Undecided
|
Billy Earney |
Bug Description
There are many places in the code where we use stringstream for type conversions. It usually goes something like this:
stringstream s;
s << some_int_value;
string string_
In fact, probably every use of stringstream is simply for this reason.
These should be replaced with boost::
string string_
tags: | added: low-hanging-fruit |
Changed in drizzle: | |
importance: | Undecided → High |
status: | New → Triaged |
Changed in drizzle: | |
assignee: | nobody → Monty Taylor (mordred) |
Changed in drizzle: | |
assignee: | Monty Taylor (mordred) → Billy Earney (billy-earney) |
Changed in drizzle: | |
status: | Triaged → Fix Released |
To post a comment you must log in.
explain_plan.cc:398
s << uppercase << hex << tmp.to_ulong();
iostream conversion offers convenient formatting options. In general, where formatting is essential to the conversion I assume keeping the stringstream conversion is desired. Is this a correct assumption?