gir1.0-syncdaemon-1.0 should depend on gir1.0-dbus-1.0

Bug #621084 reported by Roman Yepishev
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Fix Released
Medium
Rodrigo Moya
ubuntuone-client (Ubuntu)
Fix Released
Medium
Unassigned
Maverick
Fix Released
Undecided
Unassigned
Natty
Fix Released
Medium
Unassigned

Bug Description

In case only gir1.0-syncdaemon-1.0 is installed, it will not work causing the following error on

>>> from gi.repository import SyncDaemon
...
Typelib file for namespace 'DBus', version '1.0' not found

gir1.0-syncdaemon-1.0 should have gir1.0-dbus-1.0 in package dependencies.

Related branches

Roman Yepishev (rye)
description: updated
summary: - gir1.0-ubuntuone-1.0 should depend on gir1.0-dbus-1.0
+ gir1.0-syncdaemon-1.0 should depend on gir1.0-dbus-1.0
Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

hmm, I don't understand why it depends on DBus introspection, there's nothing DBus-related exposed in the API, it's just an internal dependency, which should already be taken care of by the dependencies in libsyncdaemon package

tags: added: desktop+ u1-maverick-sru
Changed in ubuntuone-client:
assignee: Ubuntu One Desktop+ team (ubuntuone-desktop+) → Rodrigo Moya (rodrigo-moya)
Changed in ubuntuone-client:
status: Confirmed → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted ubuntuone-client into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in ubuntuone-client (Ubuntu Maverick):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

This bug doesn't include a test case for SRU verification.

>>> from gi.repository import SyncDaemon

This looks like python, but running this command returns the following error for me:

>>> from gi.repository import SyncDaemon
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named gi.repository

How can we verify this fix?

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Steve, you need to install gir1.0-syncdaemon-1.0, which I think should pull all the needed dependencies

Revision history for this message
Steve Langasek (vorlon) wrote :

Er, no, I obviously installed gir1.0-syncdaemon-1.0 to test this, as that's the very package being verified here. Installing this package doesn't pull anything that exposes a 'gi.repository' to python, so I don't know how to test this in a pristine environment.

In any case, I've just checked the dependencies of the gir1.0-syncdaemon-1.0 package in maverick-proposed, and it has *no* Depends: line at all (neither does the previous version). So given the subject of this bug report, I'm going to mark this SRU verification-failed.

tags: added: verification-failed
removed: verification-needed
Revision history for this message
dobey (dobey) wrote :

Steve: looking at the branch that was merged to fix this, it seems as though the dependency on dbus in the gir was removed. As a result, adding the depend in the package is no longer necessary. To test the import from python, you'll need to install python-gobject. As gobject-introspection is meant to be language independent, having a dependency on that from the package that provides the .gir files, is wrong.

I guess there is no clear policy on such things in Debian. Perhaps there needs to be some sort of meta dependency on a "gir-parser" or something, which python-gobject, and whatever else, can all provide.

Revision history for this message
Steve Langasek (vorlon) wrote :

Hi Rodney,

Ok, thanks for the clarification. I understood that the gir files were language-independent and shouldn't depend on whatever python package provides gi.repository... I just couldn't figure out what provided gi.repository so I could manually test :)

After installing python-gobject and gir1.0-syncdaemon-1.0, without gir1.0-dbus-1.0, I'm able to confirm that this import fails with the maverick-updates version of the package and succeeds with the maverick-proposed version. Flipping to verification-done.

tags: added: verification-done
removed: verification-failed
Revision history for this message
Martin Pitt (pitti) wrote :

Please fix this (and the other bugs of this SRU) in natty first, so that this can progress to -updates.

dobey (dobey)
Changed in ubuntuone-client (Ubuntu Natty):
importance: Undecided → Medium
status: New → Fix Released
Revision history for this message
dobey (dobey) wrote :

Martin, the bugs in this SRU of ubuntuone-client are all fixed in natty. I've gone through and added the targets for them, and set their statuses to Fix Released.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 1.4.5-0ubuntu1

---------------
ubuntuone-client (1.4.5-0ubuntu1) maverick-proposed; urgency=low

  * New upstream release:
    - Add Ubuntu One root dir to Nautilus places (Rodrigo Moya) (LP: #641287)
    - Fix translation of SSO help text (Rodrigo Moya) (LP: #647483)
    - Wait for READY signal even if dbus client calls d.errback (Roman Yepishev)
      (LP: #651237)
    - Don't depend on DBus introspection, we don't need it (Rodrigo Moya)
      (LP: #621084)
 -- Rodrigo Moya <email address hidden> Thu, 14 Oct 2010 17:52:03 +0200

Changed in ubuntuone-client (Ubuntu Maverick):
status: Fix Committed → Fix Released
dobey (dobey)
Changed in ubuntuone-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.